Re: [PATCH 4/4] arm64: dts: rockchip: Add Radxa e20c board

Yao Zi
2024-08-03T13:53:06Z

On Sat, Aug 03, 2024 at 12:55:11PM +0000, Yao Zi wrote:
> Add board-level device tree for Radxa e20c board[1]. This basic
> implementation supports boot into a kernel with only UART console.
> Other features will be added later.
>
> [1]: https://docs.radxa.com/en/e/e20c
>
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3528-radxa-e20c.dts | 22 +++++++++++++++++++
> 2 files changed, 23 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index fda1b980eb4b..ecdd767d0323 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -74,6 +74,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire-excavator.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3528-radxa-e20c.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg-arc-d.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg-arc-s.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-anbernic-rg353p.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts b/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts
> new file mode 100644
> index 000000000000..534bd47e9971
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts
> @@ -0,0 +1,22 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (c) 2020 Rockchip Electronics Co., Ltd
> + * Copyright (c) 2024 Radxa Limited
> + * Copyright (c) 2024 Yao Zi <ziyao@disroot.org>
> + */
> +
> +/dts-v1/;
> +#include "rk3528.dtsi"
> +
> +/ {
> + model = "Radxa E20C";
> + compatible = "radxa,e20c", "rockchip,rk3528";
> +
> + chosen {
> + stdout-path = "serial5:115200n8";

There is an error, stdout-path should be "serial0:1500000n8".
Sorry for my mistake, will be corrected in next revision.

Best regards,
Yao Zi