Re: [PATCH 3/4] arm64: dts: rockchip: Add base DT for rk3528 SoC

Krzysztof Kozlowski
2024-08-04T14:09:18Z

On 04/08/2024 14:49, Heiko Stübner wrote:
>
>>> + compatible = "fixed-clock";
>>> + #clock-cells = <0>;
>>> + clock-frequency = <24000000>;
>>> + clock-output-names = "xin24m";
>>> + };
>>> +
>>> + gic: interrupt-controller@fed01000 {
>>
>> Why this all is outside of SoC?
>
> I guess you mean outside of a "soc {}" node?
>
> Here the rk3528 simply follows all other Rockchip SoCs :-) .
>
> Digging into the history, the first rk3066a and initial rk3288 submission
> did use a soc {} node, which later got removed as suggested by arm-soc
> maintainers at the time [0].
>
> I guess that changed since then?

Well, referenced patch was mixing MMIO with non-MMIO, so Olof's comment
could be understood that this is not correct approach. Even though DT
spec shows examples of "soc", it is not required. But then how do you
implement any ordering? By name or by unit address?

IOW, I think this is the only platform not using "soc" nodes.

Best regards,
Krzysztof