Re: [PATCH 3/4] arm64: dts: rockchip: Add base DT for rk3528 SoC

Heiko Stübner
2024-08-04T12:49:59Z

Hi Krzysztof,

Am Sonntag, 4. August 2024, 12:05:11 CEST schrieb Krzysztof Kozlowski:
> On 03/08/2024 14:55, Yao Zi wrote:
> > This initial device tree describes CPU, interrupts and UART on the chip
> > and is able to boot into basic kernel with only UART. Cache information
> > is omitted for now as there is no precise documentation. Support for
> > other features will be added later.
> >
> > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > ---

> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <24000000>;
> > + clock-output-names = "xin24m";
> > + };
> > +
> > + gic: interrupt-controller@fed01000 {
>
> Why this all is outside of SoC?

I guess you mean outside of a "soc {}" node?

Here the rk3528 simply follows all other Rockchip SoCs :-) .

Digging into the history, the first rk3066a and initial rk3288 submission
did use a soc {} node, which later got removed as suggested by arm-soc
maintainers at the time [0].

I guess that changed since then?

Heiko

[0] https://lore.kernel.org/linux-arm-kernel/20140716005528.GA26207@quad.lixom.net/