From: Craig Shelley <craig@microtron.org.uk>
To: linux-serial@vger.kernel.org
Subject: tx_loadsz setserial bug?
Date: Fri, 11 Mar 2005 15:40:20 +0000 [thread overview]
Message-ID: <1110555620.7777.19.camel@localhost> (raw)
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
Hi,
I think there may be a bug in 8250.c (linux 2.6.10) whereby tx_loadsz
(and possibly other info) is not updated when changing the uart type
using setserial eg
# setserial /dev/ttyS4
/dev/ttyS4, UART: 16550A, Port: 0xd000, IRQ: 5
# setserial /dev/ttyS4 uart 16550
# setserial /dev/ttyS4
/dev/ttyS4, UART: 16550, Port: 0xd000, IRQ: 5
Since tc_loadsz only gets set during autoconfig, it doesn't reflect the
port settings made using setserial
Replacing
count = up->tx_loadsz;
With
count = uart_config[up->port.type].tx_loadsz;
On line 1122 seemed to cure my problem as a temporary bodge fix, but it
looks like a more significant alteration is required in order to fix it
properly.
--
Craig Shelley
EMail: craig@microtron.org.uk
Jabber: shell@jabber.earth.li
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
reply other threads:[~2005-03-11 15:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110555620.7777.19.camel@localhost \
--to=craig@microtron.org.uk \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox