* [2.6 patch] drivers/serial/8250_acpi.c: fix a warning @ 2005-04-15 15:10 Adrian Bunk 2005-04-15 16:10 ` Alexey Dobriyan 0 siblings, 1 reply; 7+ messages in thread From: Adrian Bunk @ 2005-04-15 15:10 UTC (permalink / raw) To: Andrew Morton; +Cc: Bjorn Helgaas, rmk+serial, linux-serial, linux-kernel This patch fixes the following warning: <-- snip --> ... CC drivers/serial/8250_acpi.o drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi' ... <-- snip --> This patch was already ACK'ed by Bjorn Helgaas. Signed-off-by: Adrian Bunk <bunk@stusta.de> --- This patch was already sent on: - 5 Apr 2005 --- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old 2005-04-05 15:58:59.000000000 +0200 +++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c 2005-04-05 16:01:47.000000000 +0200 @@ -9,6 +9,7 @@ * (at your option) any later version. */ +#include <linux/config.h> #include <linux/acpi.h> #include <linux/init.h> #include <linux/module.h> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning 2005-04-15 15:10 [2.6 patch] drivers/serial/8250_acpi.c: fix a warning Adrian Bunk @ 2005-04-15 16:10 ` Alexey Dobriyan 2005-04-16 2:38 ` Adrian Bunk 0 siblings, 1 reply; 7+ messages in thread From: Alexey Dobriyan @ 2005-04-15 16:10 UTC (permalink / raw) To: Adrian Bunk Cc: Andrew Morton, Bjorn Helgaas, rmk+serial, linux-serial, linux-kernel On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote: > This patch fixes the following warning: > CC drivers/serial/8250_acpi.o > drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': > drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi' > --- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old > +++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c > +#include <linux/config.h> drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning 2005-04-15 16:10 ` Alexey Dobriyan @ 2005-04-16 2:38 ` Adrian Bunk 2005-04-16 3:08 ` Herbert Xu 2005-04-16 7:59 ` Russell King 0 siblings, 2 replies; 7+ messages in thread From: Adrian Bunk @ 2005-04-16 2:38 UTC (permalink / raw) To: Alexey Dobriyan Cc: Andrew Morton, Bjorn Helgaas, rmk+serial, linux-serial, linux-kernel, len.brown, acpi-devel On Fri, Apr 15, 2005 at 08:10:54PM +0400, Alexey Dobriyan wrote: > On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote: > > > This patch fixes the following warning: > > > CC drivers/serial/8250_acpi.o > > drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': > > drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi' > > > --- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old > > +++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c > > > +#include <linux/config.h> > > drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols. 8250_acpi.c #include's <acpi/acpi_bus.h> which requires config.h . In the Linux kernel, it's more common to put such header dependencies for header files into the C files, but if the ACPI people agree a patch to add the #include <linux/config.h> to acpi_bus.h is the other possble correct solution for this issue. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning 2005-04-16 2:38 ` Adrian Bunk @ 2005-04-16 3:08 ` Herbert Xu 2005-04-16 7:59 ` Russell King 1 sibling, 0 replies; 7+ messages in thread From: Herbert Xu @ 2005-04-16 3:08 UTC (permalink / raw) To: Adrian Bunk Cc: adobriyan, akpm, bjorn.helgaas, rmk+serial, linux-serial, linux-kernel, len.brown, acpi-devel Adrian Bunk <bunk@stusta.de> wrote: > >> drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols. > > 8250_acpi.c #include's <acpi/acpi_bus.h> which requires config.h . > > In the Linux kernel, it's more common to put such header dependencies > for header files into the C files, but if the ACPI people agree a patch I disagree with this assertion. Try grep -l linux/config.h include/linux/*.h | wc -l Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning 2005-04-16 2:38 ` Adrian Bunk 2005-04-16 3:08 ` Herbert Xu @ 2005-04-16 7:59 ` Russell King 2005-04-17 18:19 ` [2.6 patch] ACPI: add two missing config.h #include's Adrian Bunk 1 sibling, 1 reply; 7+ messages in thread From: Russell King @ 2005-04-16 7:59 UTC (permalink / raw) To: Adrian Bunk Cc: Alexey Dobriyan, Andrew Morton, Bjorn Helgaas, linux-serial, linux-kernel, len.brown, acpi-devel On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote: > In the Linux kernel, it's more common to put such header dependencies > for header files into the C files, but if the ACPI people agree a patch > to add the #include <linux/config.h> to acpi_bus.h is the other possble > correct solution for this issue. With the exception of linux/config.h. Do a 'make configcheck' and it'll tell you where linux/config.h is missing and where it shouldn't be. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core ^ permalink raw reply [flat|nested] 7+ messages in thread
* [2.6 patch] ACPI: add two missing config.h #include's 2005-04-16 7:59 ` Russell King @ 2005-04-17 18:19 ` Adrian Bunk 2005-04-26 5:43 ` Len Brown 0 siblings, 1 reply; 7+ messages in thread From: Adrian Bunk @ 2005-04-17 18:19 UTC (permalink / raw) To: Alexey Dobriyan, Andrew Morton, Bjorn Helgaas, linux-serial, linux-kernel, len.brown, acpi-devel, Herbert Xu On Sat, Apr 16, 2005 at 08:59:23AM +0100, Russell King wrote: > On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote: > > In the Linux kernel, it's more common to put such header dependencies > > for header files into the C files, but if the ACPI people agree a patch > > to add the #include <linux/config.h> to acpi_bus.h is the other possble > > correct solution for this issue. > > With the exception of linux/config.h. > > Do a 'make configcheck' and it'll tell you where linux/config.h is missing > and where it shouldn't be. OK, then the patch below is the correct solution. cu Adrian <-- snip --> This patch fixes the following warning by adding two missing config.h #include's: <-- snip --> ... CC drivers/serial/8250_acpi.o drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi' ... <-- snip --> Signed-off-by: Adrian Bunk <bunk@stusta.de> --- linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h.old 2005-04-17 19:05:23.000000000 +0200 +++ linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h 2005-04-17 19:05:37.000000000 +0200 @@ -26,6 +26,7 @@ #ifndef __ACPI_BUS_H__ #define __ACPI_BUS_H__ +#include <linux/config.h> #include <linux/kobject.h> #include <acpi/acpi.h> --- linux-2.6.12-rc2-mm3-full/include/linux/acpi.h.old 2005-04-17 19:25:51.000000000 +0200 +++ linux-2.6.12-rc2-mm3-full/include/linux/acpi.h 2005-04-17 19:24:54.000000000 +0200 @@ -25,6 +25,8 @@ #ifndef _LINUX_ACPI_H #define _LINUX_ACPI_H +#include <linux/config.h> + #ifdef CONFIG_ACPI #ifndef _LINUX ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] ACPI: add two missing config.h #include's 2005-04-17 18:19 ` [2.6 patch] ACPI: add two missing config.h #include's Adrian Bunk @ 2005-04-26 5:43 ` Len Brown 0 siblings, 0 replies; 7+ messages in thread From: Len Brown @ 2005-04-26 5:43 UTC (permalink / raw) To: Adrian Bunk Cc: Alexey Dobriyan, Andrew Morton, Bjorn Helgaas, linux-serial, linux-kernel, ACPI Developers, Herbert Xu Applied. thanks, -Len On Sun, 2005-04-17 at 14:19, Adrian Bunk wrote: > On Sat, Apr 16, 2005 at 08:59:23AM +0100, Russell King wrote: > > On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote: > > > In the Linux kernel, it's more common to put such header > dependencies > > > for header files into the C files, but if the ACPI people agree a > patch > > > to add the #include <linux/config.h> to acpi_bus.h is the other > possble > > > correct solution for this issue. > > > > With the exception of linux/config.h. > > > > Do a 'make configcheck' and it'll tell you where linux/config.h is > missing > > and where it shouldn't be. > > OK, then the patch below is the correct solution. > > cu > Adrian > > > <-- snip --> > > > This patch fixes the following warning by adding two missing config.h > #include's: > > <-- snip --> > > ... > CC drivers/serial/8250_acpi.o > drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': > drivers/serial/8250_acpi.c:51: warning: implicit declaration of > function > `acpi_register_gsi' > ... > > <-- snip --> > > Signed-off-by: Adrian Bunk <bunk@stusta.de> > > --- linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h.old > 2005-04-17 19:05:23.000000000 +0200 > +++ linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h 2005-04-17 > 19:05:37.000000000 +0200 > @@ -26,6 +26,7 @@ > #ifndef __ACPI_BUS_H__ > #define __ACPI_BUS_H__ > > +#include <linux/config.h> > #include <linux/kobject.h> > > #include <acpi/acpi.h> > --- linux-2.6.12-rc2-mm3-full/include/linux/acpi.h.old 2005-04-17 > 19:25:51.000000000 +0200 > +++ linux-2.6.12-rc2-mm3-full/include/linux/acpi.h 2005-04-17 > 19:24:54.000000000 +0200 > @@ -25,6 +25,8 @@ > #ifndef _LINUX_ACPI_H > #define _LINUX_ACPI_H > > +#include <linux/config.h> > + > #ifdef CONFIG_ACPI > > #ifndef _LINUX > > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2005-04-26 5:45 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2005-04-15 15:10 [2.6 patch] drivers/serial/8250_acpi.c: fix a warning Adrian Bunk 2005-04-15 16:10 ` Alexey Dobriyan 2005-04-16 2:38 ` Adrian Bunk 2005-04-16 3:08 ` Herbert Xu 2005-04-16 7:59 ` Russell King 2005-04-17 18:19 ` [2.6 patch] ACPI: add two missing config.h #include's Adrian Bunk 2005-04-26 5:43 ` Len Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).