From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: New serial speed handling: First implementation Date: Fri, 25 Aug 2006 21:44:57 +0100 Message-ID: <1156538697.3007.256.camel@localhost.localdomain> References: <1156518953.3007.247.camel@localhost.localdomain> <20060825174131.GA725@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:41350 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S932394AbWHYUXZ (ORCPT ); Fri, 25 Aug 2006 16:23:25 -0400 In-Reply-To: <20060825174131.GA725@flint.arm.linux.org.uk> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Russell King Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Ar Gwe, 2006-08-25 am 18:41 +0100, ysgrifennodd Russell King: > On Fri, Aug 25, 2006 at 04:15:53PM +0100, Alan Cox wrote: > > diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-rc4-mm2/include/asm-i386/ioctls.h linux-2.6.18-rc4-mm2/include/asm-i386/ioctls.h > > --- linux.vanilla-2.6.18-rc4-mm2/include/asm-i386/ioctls.h 2006-08-21 14:17:52.000000000 +0100 > > +++ linux-2.6.18-rc4-mm2/include/asm-i386/ioctls.h 2006-08-25 11:23:20.000000000 +0100 > > @@ -47,6 +47,12 @@ > > #define TIOCSBRK 0x5427 /* BSD compatibility */ > > #define TIOCCBRK 0x5428 /* BSD compatibility */ > > #define TIOCGSID 0x5429 /* Return the session ID of FD */ > > + > > +#define TCGETS2 0x542A > > +#define TCSETS2 0x542B > > +#define TCSETSW2 0x542C > > +#define TCSETSF2 0x542D > > + > > Wouldn't it be better to use the _IO* macros to define these new ioctls? > Ditto for other architectures. That really is up to you. For x86/x86-64 it would break the internal consistency.