From: Jiri Slaby <jirislaby@kernel.org>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-mips@vger.kernel.org, Jonas Gorski <jonas.gorski@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/6] serial: 8250: remove AR7 support
Date: Thu, 21 Sep 2023 13:21:46 +0200 [thread overview]
Message-ID: <1165e159-62d1-4abd-88d7-b8eaeaf797df@kernel.org> (raw)
In-Reply-To: <ZQwl+OXvhA6/x6f1@smile.fi.intel.com>
On 21. 09. 23, 13:16, Andy Shevchenko wrote:
> On Thu, Sep 21, 2023 at 12:36:05PM +0200, Philippe Mathieu-Daudé wrote:
>> On 20/9/23 22:10, Wolfram Sang wrote:
>
>>> --- a/include/uapi/linux/serial_core.h
>>> +++ b/include/uapi/linux/serial_core.h
>>> @@ -32,7 +32,6 @@
>>> #define PORT_XSCALE 15
>>> #define PORT_RM9000 16 /* PMC-Sierra RM9xxx internal UART */
>>> #define PORT_OCTEON 17 /* Cavium OCTEON internal UART */
>>> -#define PORT_AR7 18 /* Texas Instruments AR7 internal UART */
>>
>> I'm a bit surprised definitions are removed from the uAPI, isn't
>> it expected to be very stable? Shouldn't it be better to keep it
>> defined but modify the comment, mentioning "obsolete" or "deprecated"?
>
> The numbers up to 20 must stay, they are being used somewhere, setserial
> implementation in busybox (IIRC).
But they define it if we don't:
#ifndef PORT_AR7
# define PORT_AR7 18
#endif
> NAK.
I don't mind either way. But likely we should reserve the field if we go
and remove it (setserial has a number->string mapping in busybox). Hm,
then reserving it or keep it? Perhaps keep it is better... So ack the
NACK :).
--
js
suse labs
next prev parent reply other threads:[~2023-09-21 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 20:10 [PATCH 0/6] remove AR7 platform and associated drivers Wolfram Sang
2023-09-20 20:10 ` [PATCH 1/6] serial: 8250: remove AR7 support Wolfram Sang
2023-09-20 21:25 ` Florian Fainelli
2023-09-21 7:31 ` Greg Kroah-Hartman
2023-09-21 10:36 ` Philippe Mathieu-Daudé
2023-09-21 11:16 ` Andy Shevchenko
2023-09-21 11:21 ` Jiri Slaby [this message]
2023-09-21 11:30 ` Andy Shevchenko
2023-09-21 12:04 ` Wolfram Sang
2023-09-21 11:18 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165e159-62d1-4abd-88d7-b8eaeaf797df@kernel.org \
--to=jirislaby@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=philmd@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).