From: Dmitry Safonov <0x7f454c46@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v1 1/4] serial: core: Use string length for SysRq magic sequence
Date: Tue, 10 Mar 2020 17:06:02 +0000 [thread overview]
Message-ID: <11b21afc-fbd8-a148-de69-077fcbc928fa@gmail.com> (raw)
In-Reply-To: <20200310164851.GT1922688@smile.fi.intel.com>
On 3/10/20 4:48 PM, Andy Shevchenko wrote:
>
> Have you seen to the assembly?
>
> For me it seems that GCC is clever enough to precalc length for constant
> literals.
>
> With default string (empty) there is no uart_sysrq_on() at all in the code.
>
> With "pqr" I see this function and in particular:
> 621: be 03 00 00 00 mov $0x3,%esi
>
> With "pqrst"
>
> 621: be 05 00 00 00 mov $0x5,%esi
>
> (Note, I compiled entire series, that's why uart_sysrq_on() has strlen() in)
Ah, that solves all worries I have.
Thanks again,
Dmitry
next prev parent reply other threads:[~2020-03-10 17:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 13:20 [PATCH v1 1/4] serial: core: Use string length for SysRq magic sequence Andy Shevchenko
2020-03-10 13:20 ` [PATCH v1 2/4] serial: core: Print escaped SysRq Magic sequence if enabled Andy Shevchenko
2020-03-10 14:40 ` Dmitry Safonov
2020-03-10 13:20 ` [PATCH v1 3/4] serial: core: Use uart_console() helper in SysRq code Andy Shevchenko
2020-03-10 14:43 ` Dmitry Safonov
2020-03-10 13:20 ` [PATCH v1 4/4] serial: core: Refactor uart_unlock_and_check_sysrq() Andy Shevchenko
2020-03-10 14:48 ` Dmitry Safonov
2020-03-10 15:30 ` Andy Shevchenko
2020-03-10 14:38 ` [PATCH v1 1/4] serial: core: Use string length for SysRq magic sequence Dmitry Safonov
2020-03-10 14:57 ` Andy Shevchenko
2020-03-10 15:33 ` Andy Shevchenko
2020-03-10 15:57 ` Dmitry Safonov
2020-03-10 16:48 ` Andy Shevchenko
2020-03-10 17:06 ` Dmitry Safonov [this message]
2020-03-10 17:06 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11b21afc-fbd8-a148-de69-077fcbc928fa@gmail.com \
--to=0x7f454c46@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).