From: Bryan Wu <cooloney@kernel.org>
To: alan@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Graf Yang <graf.yang@analog.com>, Bryan Wu <cooloney@kernel.org>
Subject: [PATCH 3/9] Blackfin Serial Driver: use barrier instead of cpu_relax for Blackfin SMP like patch
Date: Fri, 17 Oct 2008 01:44:01 +0800 [thread overview]
Message-ID: <1224179047-13073-4-git-send-email-cooloney@kernel.org> (raw)
In-Reply-To: <1224179047-13073-1-git-send-email-cooloney@kernel.org>
From: Graf Yang <graf.yang@analog.com>
We are making a SMP like patch to blackfin, cpu_relax() is replaced by a
data cache flush function which will count it to a per-cpu counter.
If this serial function is called too early, the per-cpu data area have
not been initialized, this call will cause crash.
So we'd like to use barrier() instead of cpu_relax().
Signed-off-by: Graf Yang <graf.yang@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
---
drivers/serial/bfin_5xx.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c
index 16b891e..aea3a53 100644
--- a/drivers/serial/bfin_5xx.c
+++ b/drivers/serial/bfin_5xx.c
@@ -1107,7 +1107,8 @@ static __init void early_serial_putc(struct uart_port *port, int ch)
struct bfin_serial_port *uart = (struct bfin_serial_port *)port;
while ((!(UART_GET_LSR(uart) & THRE)) && --timeout)
- cpu_relax();
+ barrier();
+
UART_PUT_CHAR(uart, ch);
}
--
1.5.6
next prev parent reply other threads:[~2008-10-16 17:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 17:43 [PATCH 0/9] Blacfin Serial Driver updates for 2.6.28-rc1 (v2) Bryan Wu
2008-10-16 17:43 ` [PATCH 1/9] Blackfin Serial Driver: updates kgdb over Blackfin serial driver with kgdb framework Bryan Wu
2008-10-17 17:41 ` Alan Cox
2008-10-16 17:44 ` [PATCH 2/9] Blackfin Serial Driver: Add a debug function to serial driver Bryan Wu
2008-10-16 17:44 ` Bryan Wu [this message]
2008-10-16 17:44 ` [PATCH 4/9] Blackfin Serial Driver: fix bug - SIR driver stop receiving randomly Bryan Wu
2008-10-16 17:44 ` [PATCH 5/9] Blackfin Serial Driver: Clean serial console and early prink code` Bryan Wu
2008-10-16 17:44 ` [PATCH 6/9] Blackfin Serial Driver: Fix bug - BF527-EZKIT unable to receive large files over UART in DMA mode Bryan Wu
2008-10-16 17:44 ` [PATCH 7/9] Blackfin Serial Driver: Remove BI status for known_good_char Bryan Wu
2008-10-16 17:44 ` [PATCH 8/9] Blackfin Serial Driver: fix a in dma circle rx buffer handling Bryan Wu
2008-10-16 17:44 ` [PATCH 9/9] Blackfin Serial Driver: Change hardware flowcontrol from poll to interrupt driven Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224179047-13073-4-git-send-email-cooloney@kernel.org \
--to=cooloney@kernel.org \
--cc=alan@redhat.com \
--cc=graf.yang@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox