From: David Daney <ddaney@caviumnetworks.com>
To: linux-serial@vger.kernel.org, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk
Cc: linux-mips@linux-mips.org,
David Daney <ddaney@caviumnetworks.com>,
Tomaso Paoletti <tpaoletti@caviumnetworks.com>
Subject: [PATCH 1/4] 8250: Don't clobber spinlocks.
Date: Mon, 1 Dec 2008 15:49:25 -0800 [thread overview]
Message-ID: <1228175368-5536-1-git-send-email-ddaney@caviumnetworks.com> (raw)
In-Reply-To: <4934774E.6080805@caviumnetworks.com>
In serial8250_isa_init_ports(), the port's lock is initialized. We
should not overwrite it. In early_serial_setup(), only copy in the
fields we need. Since the early console code only uses a subset of
the fields, these are sufficient.
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Signed-off-by: Tomaso Paoletti <tpaoletti@caviumnetworks.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/serial/8250.c | 15 +++++++++++++--
1 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 303272a..8e28750 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -2752,12 +2752,23 @@ static struct uart_driver serial8250_reg = {
*/
int __init early_serial_setup(struct uart_port *port)
{
+ struct uart_port *p;
+
if (port->line >= ARRAY_SIZE(serial8250_ports))
return -ENODEV;
serial8250_isa_init_ports();
- serial8250_ports[port->line].port = *port;
- serial8250_ports[port->line].port.ops = &serial8250_pops;
+ p = &serial8250_ports[port->line].port;
+ p->iobase = port->iobase;
+ p->membase = port->membase;
+ p->irq = port->irq;
+ p->uartclk = port->uartclk;
+ p->fifosize = port->fifosize;
+ p->regshift = port->regshift;
+ p->iotype = port->iotype;
+ p->flags = port->flags;
+ p->mapbase = port->mapbase;
+ p->private_data = port->private_data;
return 0;
}
--
1.5.6.5
next prev parent reply other threads:[~2008-12-01 23:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 23:46 [PATCH 0/4] serial: Patches for OCTEON CPU support (version 2) David Daney
2008-12-01 23:49 ` David Daney [this message]
2008-12-02 11:20 ` [PATCH 1/4] 8250: Don't clobber spinlocks Alan Cox
2008-12-02 17:01 ` David Daney
2008-12-01 23:49 ` [PATCH 2/4] 8250: Serial driver changes to support future Cavium OCTEON serial patches David Daney
2008-12-01 23:49 ` [PATCH 3/4] Serial: Allow port type to be specified when calling serial8250_register_port David Daney
2008-12-01 23:49 ` [PATCH 4/4] Serial: UART driver changes for Cavium OCTEON David Daney
2008-12-03 15:46 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228175368-5536-1-git-send-email-ddaney@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=tpaoletti@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox