[PATCH 1/1] serial: RS485 ioctl structure uses __u32 include linux/types.h

[PATCH 1/1] serial: RS485 ioctl structure uses __u32 include linux/types.h

[Andy Whitcroft]

In the commit below a new struct serial_rs485 was introduced for a new
ioctl:

    commit c26c56c0f40e200e61d1390629c806f6adaffbcc
    Author: Alan Cox <alan@redhat.com>
    Date:   Mon Oct 13 10:37:48 2008 +0100

	tty: Cris has a nice RS485 ioctl so we should steal it

This structure uses the __u32 types for some of its members, which leads
to the following compile error:

    $ cc -I.../include -c X.c
    In file included from X.c:2: .../include/linux/serial.h:185:
		error: expected specifier-qualifier-list before ‘__u32’
    $

It seems that these types are appropriate for this structure as it is
to be exposed to userspace.  These types are available via linux/types.h
so move the include of that outside the __KERNEL__ section.

Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
 include/linux/serial.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/linux/serial.h b/include/linux/serial.h
index 1ea8d92..9136cc5 100644
--- a/include/linux/serial.h
+++ b/include/linux/serial.h
@@ -10,8 +10,9 @@
 #ifndef _LINUX_SERIAL_H
 #define _LINUX_SERIAL_H
 
-#ifdef __KERNEL__
 #include <linux/types.h>
+
+#ifdef __KERNEL__
 #include <asm/page.h>
 
 /*
-- 
1.6.0.4.911.gc990

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] serial: RS485 ioctl structure uses __u32 include linux/types.h

[Mike Frysinger]

On Tue, Dec 2, 2008 at 06:00, Andy Whitcroft <apw@canonical.com> wrote:
> In the commit below a new struct serial_rs485 was introduced for a new
> ioctl:
>
>    commit c26c56c0f40e200e61d1390629c806f6adaffbcc
>    Author: Alan Cox <alan@redhat.com>
>    Date:   Mon Oct 13 10:37:48 2008 +0100
>
>        tty: Cris has a nice RS485 ioctl so we should steal it
>
> This structure uses the __u32 types for some of its members, which leads
> to the following compile error:

looks like this was posted on Nov 3 already ...
http://lkml.org/lkml/2008/11/3/240
-mike