* [PATCH] [bfin-sport-uart] The waiting loop to stop SPORT TX from TX interrupt is too long
@ 2009-09-21 11:02 sonic zhang
0 siblings, 0 replies; only message in thread
From: sonic zhang @ 2009-09-21 11:02 UTC (permalink / raw)
To: Alan Cox, Linux Kernel, Linux Serial
The waiting loop to stop SPORT TX from TX interrupt is
too long. This may block SPORT RX interrupts and cause
RX FIFO overflow. So, do stop sport TX only after the last
char in TX FIFO is moved into the shift register.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
---
drivers/serial/bfin_sport_uart.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/bfin_sport_uart.c b/drivers/serial/bfin_sport_uart.c
index c108b1a..fb9f7cd 100644
--- a/drivers/serial/bfin_sport_uart.c
+++ b/drivers/serial/bfin_sport_uart.c
@@ -303,7 +303,13 @@ static void sport_uart_tx_chars(struct sport_uart_port *up)
}
if (uart_circ_empty(xmit) || uart_tx_stopped(&up->port)) {
- sport_stop_tx(&up->port);
+ /* The waiting loop to stop SPORT TX from TX interrupt is
+ * too long. This may block SPORT RX interrupts and cause
+ * RX FIFO overflow. So, do stop sport TX only after the last
+ * char in TX FIFO is moved into the shift register.
+ */
+ if (SPORT_GET_STAT(up) & TXHRE)
+ sport_stop_tx(&up->port);
return;
}
--
1.6.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-09-21 11:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-21 11:02 [PATCH] [bfin-sport-uart] The waiting loop to stop SPORT TX from TX interrupt is too long sonic zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).