linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vikram Pandita <vikram.pandita@ti.com>
To: linux-serial@vger.kernel.org, akpm@linux-foundation.org
Cc: alan@lxorguk.ukuu.org.uk, linux-omap@vger.kernel.org,
	Vikram Pandita <vikram.pandita@ti.com>
Subject: [PATCH 2/2] omap: serial: fix non-empty rx uart fifo abort
Date: Tue, 17 Nov 2009 15:17:31 -0600	[thread overview]
Message-ID: <1258492651-16002-1-git-send-email-vikram.pandita@ti.com> (raw)

OMAP3630 and OMAP4430 UART IP blocks have a restriction wrt RX FIFO.
Empty RX fifo read causes an abort. OMAP1/2/3 do not have this restriction.

so pass the flag UPF_NO_EMPTY_FIFO_READ in plat_serial8250_port, so that 8250
driver does not abort on empty rx fifo read

tested on zoom3(3630) board

Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
---
 arch/arm/mach-omap2/serial.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
index 2e17b57..669652b 100644
--- a/arch/arm/mach-omap2/serial.c
+++ b/arch/arm/mach-omap2/serial.c
@@ -624,8 +624,15 @@ void __init omap_serial_early_init(void)
 		uart->p = p;
 		list_add_tail(&uart->node, &uart_list);
 
-		if (cpu_is_omap44xx())
+		if (cpu_is_omap44xx()) {
 			p->irq += 32;
+			/* Do not read empty UART fifo on omap4 */
+			p->flags |= UPF_NO_EMPTY_FIFO_READ;
+		}
+
+		/* Do not read empty UART fifo on omap3630 */
+		if (cpu_is_omap3630())
+			p->flags |= UPF_NO_EMPTY_FIFO_READ;
 
 		omap_uart_enable_clocks(uart);
 	}
-- 
1.6.5.1.69.g36942


                 reply	other threads:[~2009-11-17 21:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258492651-16002-1-git-send-email-vikram.pandita@ti.com \
    --to=vikram.pandita@ti.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).