uartlite - fix poll support

uartlite - fix poll support

[Michal Simek]

Hi,

I forget to CC Peter Korsgaard (sorry for that again) and he found one obscure thing
in my first patch. This second patch removes it. It will be the best
to add those two patches together but I am not sure if is possible. It depends
on Greg maintaining process. (If is possible I would like to ask for it).

Peter: I added your Signed-off-by line I hope that you are OK with it.

Greg: If there are no problems with it, please add to your tty tree or add together
with the first patch.

Thanks,
Michal

[PATCH] serial: uartlite: Remove obscure loop from ulite_get_poll_char

[Michal Simek]

The previous patch
"serial: Add CONSOLE_POLL support for uartlite"
(sha1 id 52ea4a7ef12f286bd68d13a93daaa688f56a1e14)
contained obcure loop in ulite_get_poll_char function.

Signed-off-by: Michal Simek <monstr@monstr.eu>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 drivers/serial/uartlite.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/uartlite.c b/drivers/serial/uartlite.c
index c0fae0d..c4bf54b 100644
--- a/drivers/serial/uartlite.c
+++ b/drivers/serial/uartlite.c
@@ -325,7 +325,7 @@ static int ulite_verify_port(struct uart_port *port, struct serial_struct *ser)
 #ifdef CONFIG_CONSOLE_POLL
 static int ulite_get_poll_char(struct uart_port *port)
 {
-	while (!(ioread32be(port->membase + ULITE_STATUS)
+	if (!(ioread32be(port->membase + ULITE_STATUS)
 						& ULITE_STATUS_RXVALID))
 		return NO_POLL_CHAR;
 
-- 
1.5.5.6

Re: [PATCH] serial: uartlite: Remove obscure loop from ulite_get_poll_char

[Greg KH]

On Wed, Aug 25, 2010 at 02:55:04PM +0200, Michal Simek wrote:
> The previous patch
> "serial: Add CONSOLE_POLL support for uartlite"
> (sha1 id 52ea4a7ef12f286bd68d13a93daaa688f56a1e14)
> contained obcure loop in ulite_get_poll_char function.

I've merged this with the original patch so as to not have a problem.

thanks,

greg k-h

Re: [PATCH] serial: uartlite: Remove obscure loop from ulite_get_poll_char

[Michal Simek]

Greg KH wrote:
> On Wed, Aug 25, 2010 at 02:55:04PM +0200, Michal Simek wrote:
>> The previous patch
>> "serial: Add CONSOLE_POLL support for uartlite"
>> (sha1 id 52ea4a7ef12f286bd68d13a93daaa688f56a1e14)
>> contained obcure loop in ulite_get_poll_char function.
> 
> I've merged this with the original patch so as to not have a problem.


Thanks and sorry for the problem,
Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian