From: Michal Simek <monstr@monstr.eu>
To: linux-kernel@vger.kernel.org
Cc: linux-serial@vger.kernel.org, gregkh@suse.de,
Michal Simek <monstr@monstr.eu>,
Peter Korsgaard <jacmet@sunsite.dk>
Subject: [PATCH] serial: uartlite: Remove obscure loop from ulite_get_poll_char
Date: Wed, 25 Aug 2010 14:55:04 +0200 [thread overview]
Message-ID: <1282740904-1244-2-git-send-email-monstr@monstr.eu> (raw)
In-Reply-To: <1282740904-1244-1-git-send-email-monstr@monstr.eu>
The previous patch
"serial: Add CONSOLE_POLL support for uartlite"
(sha1 id 52ea4a7ef12f286bd68d13a93daaa688f56a1e14)
contained obcure loop in ulite_get_poll_char function.
Signed-off-by: Michal Simek <monstr@monstr.eu>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
drivers/serial/uartlite.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/uartlite.c b/drivers/serial/uartlite.c
index c0fae0d..c4bf54b 100644
--- a/drivers/serial/uartlite.c
+++ b/drivers/serial/uartlite.c
@@ -325,7 +325,7 @@ static int ulite_verify_port(struct uart_port *port, struct serial_struct *ser)
#ifdef CONFIG_CONSOLE_POLL
static int ulite_get_poll_char(struct uart_port *port)
{
- while (!(ioread32be(port->membase + ULITE_STATUS)
+ if (!(ioread32be(port->membase + ULITE_STATUS)
& ULITE_STATUS_RXVALID))
return NO_POLL_CHAR;
--
1.5.5.6
next prev parent reply other threads:[~2010-08-25 12:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 12:55 uartlite - fix poll support Michal Simek
2010-08-25 12:55 ` Michal Simek [this message]
2010-09-02 2:00 ` [PATCH] serial: uartlite: Remove obscure loop from ulite_get_poll_char Greg KH
2010-09-02 5:24 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282740904-1244-2-git-send-email-monstr@monstr.eu \
--to=monstr@monstr.eu \
--cc=gregkh@suse.de \
--cc=jacmet@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).