linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-serial@vger.kernel.org
Cc: Tobias Klauser <tklauser@distanz.ch>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 32/76] tty: serial: altera_uart: Use port->regshift to store bus shift
Date: Wed, 16 Mar 2011 14:12:02 -0700	[thread overview]
Message-ID: <1300309966-5745-32-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <1300309966-5745-1-git-send-email-gregkh@suse.de>

From: Tobias Klauser <tklauser@distanz.ch>

Use the regshift member of struct uart_port to store the address stride
from platform data. This way we can save one dereference per call of
altera_uart_readl and altera_uart_writel.

This also allows us to use the driver without platform data, which is
needed for device tree support in the Nios2 port.

Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/tty/serial/altera_uart.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/tty/serial/altera_uart.c b/drivers/tty/serial/altera_uart.c
index dee7a0e..3a57352 100644
--- a/drivers/tty/serial/altera_uart.c
+++ b/drivers/tty/serial/altera_uart.c
@@ -86,16 +86,12 @@ struct altera_uart {
 
 static u32 altera_uart_readl(struct uart_port *port, int reg)
 {
-	struct altera_uart_platform_uart *platp = port->private_data;
-
-	return readl(port->membase + (reg << platp->bus_shift));
+	return readl(port->membase + (reg << port->regshift));
 }
 
 static void altera_uart_writel(struct uart_port *port, u32 dat, int reg)
 {
-	struct altera_uart_platform_uart *platp = port->private_data;
-
-	writel(dat, port->membase + (reg << platp->bus_shift));
+	writel(dat, port->membase + (reg << port->regshift));
 }
 
 static unsigned int altera_uart_tx_empty(struct uart_port *port)
@@ -546,13 +542,17 @@ static int __devinit altera_uart_probe(struct platform_device *pdev)
 	if (!port->membase)
 		return -ENOMEM;
 
+	if (platp)
+		port->regshift = platp->bus_shift;
+	else
+		port->regshift = 0;
+
 	port->line = i;
 	port->type = PORT_ALTERA_UART;
 	port->iotype = SERIAL_IO_MEM;
 	port->uartclk = platp->uartclk;
 	port->ops = &altera_uart_ops;
 	port->flags = UPF_BOOT_AUTOCONF;
-	port->private_data = platp;
 
 	uart_add_one_port(&altera_uart_driver, port);
 
-- 
1.7.4.1


  parent reply	other threads:[~2011-03-16 21:13 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16 20:57 [GIT PATCH] TTY/serial driver patches for .39 Greg KH
2011-03-16 21:11 ` [PATCH 01/76] tty: serial: bfin_sport_uart: fix signedness error Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 02/76] serial: mfd: remove the timeout workaround for A0 Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 03/76] serial: ifx6x60: expanded info available from platform data Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 04/76] OMAP: Enable Magic SysRq on serial console ttyOx Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 05/76] serial: omap-serial: Enable the UART wake-up bits always Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 06/76] tty_ldisc: don't use flush_scheduled_work() Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 07/76] serial: mrst_max3110: make buffer larger Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 08/76] serial-core: reset the console speed on resume Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 09/76] 68328serial: remove unsed m68k_serial->tqueue_hangup Greg Kroah-Hartman
2011-03-16 22:41     ` Greg Ungerer
2011-03-16 21:11   ` [PATCH 10/76] serial: pch_uart: support new device ML7213 Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 11/76] serial: pch_uart: revert Kconfig for non-DMA mode Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 12/76] hvc_dcc: Fix bad code generation by marking assembly volatile Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 13/76] hvc_dcc: Simplify put_chars()/get_chars() loops Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 14/76] hvc_dcc: Simplify assembly for v6 and v7 ARM Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 15/76] vt: Add virtual console keyboard mode OFF Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 16/76] hvc: add Blackfin JTAG console support Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 17/76] TTY: use appropriate printk priority level Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 18/76] tty,vcs: lseek/VC-release race fix Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 19/76] tty,vcs removing con_buf/conf_buf_mtx Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 20/76] serial: ifx6x60: fixed call to tty_port_init Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 21/76] serial: ifx6x60: dma_alloc_coherent must use parent dev Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 22/76] serial: ifx6x60: changed internal bpw from boolean to int Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 23/76] serial: ifx6x60: set SPI max_speed_hz based on platform type Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 24/76] serial: ifx6x60: probe routine needs to call spi_setup Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 25/76] serial: ifx6x60: minor cleanup Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 26/76] serial: also set the uartclk value in resume after goes to highspeed Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 27/76] serial: change the divisor latch only when prescalar actually changed Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 28/76] tty: Add msm_smd_tty driver Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 29/76] atmel_serial: enable PPS support Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 30/76] tty,vt: fix VT_SETACTIVATE console switch Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 31/76] tty: serial: altera_uart: Handle pdev->id == -1 in altera_uart_remove Greg Kroah-Hartman
2011-03-16 21:12   ` Greg Kroah-Hartman [this message]
2011-03-16 21:12   ` [PATCH 33/76] MAINTAINERS: Add myself as a maintainer for altera_uart/altera_jtaguart Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 34/76] tiocmget: kill off the passing of the struct file Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 35/76] tiocmset: kill the file pointer argument Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 36/76] tty: remove filp from the USB tty ioctls Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 37/76] tty: now phase out the ioctl file pointer for good Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 38/76] tty: fix build error in vt_ioctl.c if CONFIG_COMPAT is enabled Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 39/76] tty: add a helper for setting termios data from kernel side Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 40/76] hci_ath: Fix the mess in this driver Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 41/76] tty: add TIOCVHANGUP to allow clean tty shutdown of all ttys Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 42/76] tty: move Kconfig entries into drivers/tty from drivers/char Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 43/76] tty: simserial: now phase out the ioctl file pointer for good Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 44/76] serial: mfd: remove the TX full-empty interrupts workaround Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 45/76] serial: mfd: add a module parameter for setting each port's working mode Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 46/76] tty: serial: altera_jtaguart: Don't use plain integer as NULL pointer Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 47/76] tty: serial: altera_jtaguart: Remove unused function early_altera_jtaguart_setup Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 48/76] tty: serial: altera_jtaguart: Support getting mapbase and IRQ from resources Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 49/76] tty: serial: altera_jtaguart: Fixup type usage of port flags Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 50/76] tty: move a number of tty drivers from drivers/char/ to drivers/tty/ Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 51/76] tty: move ipwireless driver from drivers/char/pcmcia/ " Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 52/76] tty: move obsolete and broken tty drivers to drivers/staging/tty/ Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 53/76] tty: move obsolete and broken generic_serial drivers to drivers/staging/generic_serial/ Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 54/76] pch_uart: add multi-scatter processing Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 55/76] pch_uart: add spin_lock_init Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 56/76] pch_uart : Reduce memcpy Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 57/76] pch_uart : Use dev_xxx not pr_xxx Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 58/76] pch_uart: fix uart clock setting issue Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 59/76] pch_uart: fix auto flow control miss-setting issue Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 60/76] pch_uart: fix exclusive access issue Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 61/76] pch_uart: Fix DMA channel miss-setting issue Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 62/76] tty: forgot to remove ipwireless from drivers/char/pcmcia/Makefile Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 63/76] tty: phase out of ioctl file pointer for tty3270 as well Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 64/76] MAINTAINERS: Update HVC file patterns Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 65/76] tty/serial: Relax the device_type restriction from of_serial Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 66/76] nozomi: don't use flush_scheduled_work() Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 67/76] Staging: generic_serial: fix double locking bug Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 68/76] pcmcia: synclink_cs: fix prototype for mgslpc_ioctl() Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 69/76] Staging: tty: fix build with epca.c driver Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 70/76] tty: move cd1865.h to drivers/staging/tty/ Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 71/76] tty_audit: fix tty_audit_add_data live lock on audit disabled Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 72/76] serial: msm_serial_hs: Add MSM high speed UART driver Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 73/76] n_gsm: add a documentation Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 74/76] n_gsm: fix UIH control byte : P bit should be 0 Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 75/76] pch_phub: add new device ML7213 Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 76/76] pch_uart: reference clock on CM-iTC Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300309966-5745-32-git-send-email-gregkh@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-serial@vger.kernel.org \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).