linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-serial@vger.kernel.org
Cc: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 54/76] pch_uart: add multi-scatter processing
Date: Wed, 16 Mar 2011 14:12:24 -0700	[thread overview]
Message-ID: <1300309966-5745-54-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <1300309966-5745-1-git-send-email-gregkh@suse.de>

From: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>

Currently, this driver can handle only single scatterlist.
Thus, it can't send data beyond FIFO size.

This patch enables this driver can handle multiple scatter list.

Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/tty/serial/pch_uart.c |  117 +++++++++++++++++++++++++++++++----------
 1 files changed, 89 insertions(+), 28 deletions(-)

diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
index 3b2fb93..c1386eb 100644
--- a/drivers/tty/serial/pch_uart.c
+++ b/drivers/tty/serial/pch_uart.c
@@ -226,7 +226,8 @@ struct eg20t_port {
 	struct pch_dma_slave		param_rx;
 	struct dma_chan			*chan_tx;
 	struct dma_chan			*chan_rx;
-	struct scatterlist		sg_tx;
+	struct scatterlist		*sg_tx_p;
+	int				nent;
 	struct scatterlist		sg_rx;
 	int				tx_dma_use;
 	void				*rx_buf_virt;
@@ -595,16 +596,20 @@ static void pch_dma_rx_complete(void *arg)
 	struct eg20t_port *priv = arg;
 	struct uart_port *port = &priv->port;
 	struct tty_struct *tty = tty_port_tty_get(&port->state->port);
+	int count;
 
 	if (!tty) {
 		pr_debug("%s:tty is busy now", __func__);
 		return;
 	}
 
-	if (dma_push_rx(priv, priv->trigger_level))
+	dma_sync_sg_for_cpu(port->dev, &priv->sg_rx, 1, DMA_FROM_DEVICE);
+	count = dma_push_rx(priv, priv->trigger_level);
+	if (count)
 		tty_flip_buffer_push(tty);
-
 	tty_kref_put(tty);
+	async_tx_ack(priv->desc_rx);
+	pch_uart_hal_enable_interrupt(priv, PCH_UART_HAL_RX_INT);
 }
 
 static void pch_dma_tx_complete(void *arg)
@@ -612,13 +617,21 @@ static void pch_dma_tx_complete(void *arg)
 	struct eg20t_port *priv = arg;
 	struct uart_port *port = &priv->port;
 	struct circ_buf *xmit = &port->state->xmit;
+	struct scatterlist *sg = priv->sg_tx_p;
+	int i;
 
-	xmit->tail += sg_dma_len(&priv->sg_tx);
+	for (i = 0; i < priv->nent; i++, sg++) {
+		xmit->tail += sg_dma_len(sg);
+		port->icount.tx += sg_dma_len(sg);
+	}
 	xmit->tail &= UART_XMIT_SIZE - 1;
-	port->icount.tx += sg_dma_len(&priv->sg_tx);
-
 	async_tx_ack(priv->desc_tx);
+	dma_unmap_sg(port->dev, sg, priv->nent, DMA_TO_DEVICE);
 	priv->tx_dma_use = 0;
+	priv->nent = 0;
+	kfree(priv->sg_tx_p);
+	if (uart_circ_chars_pending(xmit))
+		pch_uart_hal_enable_interrupt(priv, PCH_UART_HAL_TX_INT);
 }
 
 static int pop_tx(struct eg20t_port *priv, unsigned char *buf, int size)
@@ -682,7 +695,7 @@ static int dma_handle_rx(struct eg20t_port *priv)
 
 	sg_init_table(&priv->sg_rx, 1); /* Initialize SG table */
 
-	sg_dma_len(sg) = priv->fifo_size;
+	sg_dma_len(sg) = priv->trigger_level;
 
 	sg_set_page(&priv->sg_rx, virt_to_page(priv->rx_buf_virt),
 		     sg_dma_len(sg), (unsigned long)priv->rx_buf_virt &
@@ -692,7 +705,8 @@ static int dma_handle_rx(struct eg20t_port *priv)
 
 	desc = priv->chan_rx->device->device_prep_slave_sg(priv->chan_rx,
 			sg, 1, DMA_FROM_DEVICE,
-			DMA_PREP_INTERRUPT);
+			DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
+
 	if (!desc)
 		return 0;
 
@@ -731,6 +745,9 @@ static unsigned int handle_tx(struct eg20t_port *priv)
 		fifo_size--;
 	}
 	size = min(xmit->head - xmit->tail, fifo_size);
+	if (size < 0)
+		size = fifo_size;
+
 	tx_size = pop_tx(priv, xmit->buf, size);
 	if (tx_size > 0) {
 		ret = pch_uart_hal_write(priv, xmit->buf, tx_size);
@@ -740,8 +757,10 @@ static unsigned int handle_tx(struct eg20t_port *priv)
 
 	priv->tx_empty = tx_empty;
 
-	if (tx_empty)
+	if (tx_empty) {
 		pch_uart_hal_disable_interrupt(priv, PCH_UART_HAL_TX_INT);
+		uart_write_wakeup(port);
+	}
 
 	return PCH_UART_HANDLED_TX_INT;
 }
@@ -750,11 +769,16 @@ static unsigned int dma_handle_tx(struct eg20t_port *priv)
 {
 	struct uart_port *port = &priv->port;
 	struct circ_buf *xmit = &port->state->xmit;
-	struct scatterlist *sg = &priv->sg_tx;
+	struct scatterlist *sg;
 	int nent;
 	int fifo_size;
 	int tx_empty;
 	struct dma_async_tx_descriptor *desc;
+	int num;
+	int i;
+	int bytes;
+	int size;
+	int rem;
 
 	if (!priv->start_tx) {
 		pr_info("%s:Tx isn't started. (%lu)\n", __func__, jiffies);
@@ -772,37 +796,68 @@ static unsigned int dma_handle_tx(struct eg20t_port *priv)
 		fifo_size--;
 	}
 
-	pch_uart_hal_disable_interrupt(priv, PCH_UART_HAL_TX_INT);
+	bytes = min((int)CIRC_CNT(xmit->head, xmit->tail,
+			     UART_XMIT_SIZE), CIRC_CNT_TO_END(xmit->head,
+			     xmit->tail, UART_XMIT_SIZE));
+	if (!bytes) {
+		pch_uart_hal_disable_interrupt(priv, PCH_UART_HAL_TX_INT);
+		uart_write_wakeup(port);
+		return 0;
+	}
+
+	if (bytes > fifo_size) {
+		num = bytes / fifo_size + 1;
+		size = fifo_size;
+		rem = bytes % fifo_size;
+	} else {
+		num = 1;
+		size = bytes;
+		rem = bytes;
+	}
 
 	priv->tx_dma_use = 1;
 
-	sg_init_table(&priv->sg_tx, 1); /* Initialize SG table */
+	priv->sg_tx_p = kzalloc(sizeof(struct scatterlist)*num, GFP_ATOMIC);
+
+	sg_init_table(priv->sg_tx_p, num); /* Initialize SG table */
+	sg = priv->sg_tx_p;
 
-	sg_set_page(&priv->sg_tx, virt_to_page(xmit->buf),
-		    UART_XMIT_SIZE, (int)xmit->buf & ~PAGE_MASK);
+	for (i = 0; i < num; i++, sg++) {
+		if (i == (num - 1))
+			sg_set_page(sg, virt_to_page(xmit->buf),
+				    rem, fifo_size * i);
+		else
+			sg_set_page(sg, virt_to_page(xmit->buf),
+				    size, fifo_size * i);
+	}
 
-	nent = dma_map_sg(port->dev, &priv->sg_tx, 1, DMA_TO_DEVICE);
+	sg = priv->sg_tx_p;
+	nent = dma_map_sg(port->dev, sg, num, DMA_TO_DEVICE);
 	if (!nent) {
 		pr_err("%s:dma_map_sg Failed\n", __func__);
 		return 0;
 	}
-
-	sg->offset = xmit->tail & (UART_XMIT_SIZE - 1);
-	sg_dma_address(sg) = (sg_dma_address(sg) & ~(UART_XMIT_SIZE - 1)) +
-			      sg->offset;
-	sg_dma_len(sg) = min((int)CIRC_CNT(xmit->head, xmit->tail,
-			     UART_XMIT_SIZE), CIRC_CNT_TO_END(xmit->head,
-			     xmit->tail, UART_XMIT_SIZE));
+	priv->nent = nent;
+
+	for (i = 0; i < nent; i++, sg++) {
+		sg->offset = (xmit->tail & (UART_XMIT_SIZE - 1)) +
+			      fifo_size * i;
+		sg_dma_address(sg) = (sg_dma_address(sg) &
+				    ~(UART_XMIT_SIZE - 1)) + sg->offset;
+		if (i == (nent - 1))
+			sg_dma_len(sg) = rem;
+		else
+			sg_dma_len(sg) = size;
+	}
 
 	desc = priv->chan_tx->device->device_prep_slave_sg(priv->chan_tx,
-		sg, nent, DMA_TO_DEVICE, DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
+					priv->sg_tx_p, nent, DMA_TO_DEVICE,
+					DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
 	if (!desc) {
 		pr_err("%s:device_prep_slave_sg Failed\n", __func__);
 		return 0;
 	}
-
-	dma_sync_sg_for_device(port->dev, sg, 1, DMA_TO_DEVICE);
-
+	dma_sync_sg_for_device(port->dev, priv->sg_tx_p, nent, DMA_TO_DEVICE);
 	priv->desc_tx = desc;
 	desc->callback = pch_dma_tx_complete;
 	desc->callback_param = priv;
@@ -857,10 +912,16 @@ static irqreturn_t pch_uart_interrupt(int irq, void *dev_id)
 			}
 			break;
 		case PCH_UART_IID_RDR:	/* Received Data Ready */
-			if (priv->use_dma)
+			if (priv->use_dma) {
+				pch_uart_hal_disable_interrupt(priv,
+							PCH_UART_HAL_RX_INT);
 				ret = dma_handle_rx(priv);
-			else
+				if (!ret)
+					pch_uart_hal_enable_interrupt(priv,
+							PCH_UART_HAL_RX_INT);
+			} else {
 				ret = handle_rx(priv);
+			}
 			break;
 		case PCH_UART_IID_RDR_TO:	/* Received Data Ready
 						   (FIFO Timeout) */
-- 
1.7.4.1


  parent reply	other threads:[~2011-03-16 21:14 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16 20:57 [GIT PATCH] TTY/serial driver patches for .39 Greg KH
2011-03-16 21:11 ` [PATCH 01/76] tty: serial: bfin_sport_uart: fix signedness error Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 02/76] serial: mfd: remove the timeout workaround for A0 Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 03/76] serial: ifx6x60: expanded info available from platform data Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 04/76] OMAP: Enable Magic SysRq on serial console ttyOx Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 05/76] serial: omap-serial: Enable the UART wake-up bits always Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 06/76] tty_ldisc: don't use flush_scheduled_work() Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 07/76] serial: mrst_max3110: make buffer larger Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 08/76] serial-core: reset the console speed on resume Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 09/76] 68328serial: remove unsed m68k_serial->tqueue_hangup Greg Kroah-Hartman
2011-03-16 22:41     ` Greg Ungerer
2011-03-16 21:11   ` [PATCH 10/76] serial: pch_uart: support new device ML7213 Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 11/76] serial: pch_uart: revert Kconfig for non-DMA mode Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 12/76] hvc_dcc: Fix bad code generation by marking assembly volatile Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 13/76] hvc_dcc: Simplify put_chars()/get_chars() loops Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 14/76] hvc_dcc: Simplify assembly for v6 and v7 ARM Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 15/76] vt: Add virtual console keyboard mode OFF Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 16/76] hvc: add Blackfin JTAG console support Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 17/76] TTY: use appropriate printk priority level Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 18/76] tty,vcs: lseek/VC-release race fix Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 19/76] tty,vcs removing con_buf/conf_buf_mtx Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 20/76] serial: ifx6x60: fixed call to tty_port_init Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 21/76] serial: ifx6x60: dma_alloc_coherent must use parent dev Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 22/76] serial: ifx6x60: changed internal bpw from boolean to int Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 23/76] serial: ifx6x60: set SPI max_speed_hz based on platform type Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 24/76] serial: ifx6x60: probe routine needs to call spi_setup Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 25/76] serial: ifx6x60: minor cleanup Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 26/76] serial: also set the uartclk value in resume after goes to highspeed Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 27/76] serial: change the divisor latch only when prescalar actually changed Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 28/76] tty: Add msm_smd_tty driver Greg Kroah-Hartman
2011-03-16 21:11   ` [PATCH 29/76] atmel_serial: enable PPS support Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 30/76] tty,vt: fix VT_SETACTIVATE console switch Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 31/76] tty: serial: altera_uart: Handle pdev->id == -1 in altera_uart_remove Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 32/76] tty: serial: altera_uart: Use port->regshift to store bus shift Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 33/76] MAINTAINERS: Add myself as a maintainer for altera_uart/altera_jtaguart Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 34/76] tiocmget: kill off the passing of the struct file Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 35/76] tiocmset: kill the file pointer argument Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 36/76] tty: remove filp from the USB tty ioctls Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 37/76] tty: now phase out the ioctl file pointer for good Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 38/76] tty: fix build error in vt_ioctl.c if CONFIG_COMPAT is enabled Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 39/76] tty: add a helper for setting termios data from kernel side Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 40/76] hci_ath: Fix the mess in this driver Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 41/76] tty: add TIOCVHANGUP to allow clean tty shutdown of all ttys Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 42/76] tty: move Kconfig entries into drivers/tty from drivers/char Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 43/76] tty: simserial: now phase out the ioctl file pointer for good Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 44/76] serial: mfd: remove the TX full-empty interrupts workaround Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 45/76] serial: mfd: add a module parameter for setting each port's working mode Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 46/76] tty: serial: altera_jtaguart: Don't use plain integer as NULL pointer Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 47/76] tty: serial: altera_jtaguart: Remove unused function early_altera_jtaguart_setup Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 48/76] tty: serial: altera_jtaguart: Support getting mapbase and IRQ from resources Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 49/76] tty: serial: altera_jtaguart: Fixup type usage of port flags Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 50/76] tty: move a number of tty drivers from drivers/char/ to drivers/tty/ Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 51/76] tty: move ipwireless driver from drivers/char/pcmcia/ " Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 52/76] tty: move obsolete and broken tty drivers to drivers/staging/tty/ Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 53/76] tty: move obsolete and broken generic_serial drivers to drivers/staging/generic_serial/ Greg Kroah-Hartman
2011-03-16 21:12   ` Greg Kroah-Hartman [this message]
2011-03-16 21:12   ` [PATCH 55/76] pch_uart: add spin_lock_init Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 56/76] pch_uart : Reduce memcpy Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 57/76] pch_uart : Use dev_xxx not pr_xxx Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 58/76] pch_uart: fix uart clock setting issue Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 59/76] pch_uart: fix auto flow control miss-setting issue Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 60/76] pch_uart: fix exclusive access issue Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 61/76] pch_uart: Fix DMA channel miss-setting issue Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 62/76] tty: forgot to remove ipwireless from drivers/char/pcmcia/Makefile Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 63/76] tty: phase out of ioctl file pointer for tty3270 as well Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 64/76] MAINTAINERS: Update HVC file patterns Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 65/76] tty/serial: Relax the device_type restriction from of_serial Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 66/76] nozomi: don't use flush_scheduled_work() Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 67/76] Staging: generic_serial: fix double locking bug Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 68/76] pcmcia: synclink_cs: fix prototype for mgslpc_ioctl() Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 69/76] Staging: tty: fix build with epca.c driver Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 70/76] tty: move cd1865.h to drivers/staging/tty/ Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 71/76] tty_audit: fix tty_audit_add_data live lock on audit disabled Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 72/76] serial: msm_serial_hs: Add MSM high speed UART driver Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 73/76] n_gsm: add a documentation Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 74/76] n_gsm: fix UIH control byte : P bit should be 0 Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 75/76] pch_phub: add new device ML7213 Greg Kroah-Hartman
2011-03-16 21:12   ` [PATCH 76/76] pch_uart: reference clock on CM-iTC Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300309966-5745-54-git-send-email-gregkh@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-serial@vger.kernel.org \
    --cc=tomoya-linux@dsn.okisemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).