From: leitao@linux.vnet.ibm.com
To: gregkh@suse.de
Cc: linux-serial@vger.kernel.org, scottk@digi.com,
Breno Leitao <leitao@linux.vnet.ibm.com>,
Michael Reed <mreed@linux.vnet.ibm.com>
Subject: [PATCH] 8250: Fix capabilities when changing the port type
Date: Thu, 26 May 2011 11:18:39 -0300 [thread overview]
Message-ID: <1306419519-10669-1-git-send-email-leitao@linux.vnet.ibm.com> (raw)
In-Reply-To: <1306334898-16399-1-git-send-email-leitao@linux.vnet.ibm.com>
When changing the port type, the capabilities flags should be changed
also, otherwise the capabilities will not correspond to the port type,
which make set_sleep() crash on rmmod.
This patch just assign the correct capabilites when the port changes.
Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
CC: Michael Reed <mreed@linux.vnet.ibm.com>
---
drivers/tty/serial/8250.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/8250.c b/drivers/tty/serial/8250.c
index b40f7b9..b4129f5 100644
--- a/drivers/tty/serial/8250.c
+++ b/drivers/tty/serial/8250.c
@@ -3318,6 +3318,7 @@ void serial8250_unregister_port(int line)
uart->port.flags &= ~UPF_BOOT_AUTOCONF;
uart->port.type = PORT_UNKNOWN;
uart->port.dev = &serial8250_isa_devs->dev;
+ uart->capabilities = uart_config[uart->port.type].flags;
uart_add_one_port(&serial8250_reg, &uart->port);
} else {
uart->port.dev = NULL;
--
1.7.4.4
next prev parent reply other threads:[~2011-05-26 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 19:03 [PATCH 2/2] 8250_pci Add EEH support to the 8250 driver for IBM/Digi PCIe 2-port Adapter Michael Reed
2011-05-19 23:49 ` Greg KH
2011-05-25 14:48 ` [PATCH] 8250: Fix capabilities when changing the port type leitao
2011-05-26 14:18 ` leitao [this message]
2011-05-25 17:07 ` [PATCH] 8250_pci Add EEH support to the 8250 driver for IBM/Digi PCIe 2-port Adapter mreed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306419519-10669-1-git-send-email-leitao@linux.vnet.ibm.com \
--to=leitao@linux.vnet.ibm.com \
--cc=gregkh@suse.de \
--cc=linux-serial@vger.kernel.org \
--cc=mreed@linux.vnet.ibm.com \
--cc=scottk@digi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).