* [PATCH] drivers/tty/serial/crisv10: fix double assignment
@ 2011-07-10 23:37 Edwin van Vliet
2011-07-10 23:39 ` Jesper Juhl
0 siblings, 1 reply; 2+ messages in thread
From: Edwin van Vliet @ 2011-07-10 23:37 UTC (permalink / raw)
To: starvik, jesper.nilsson
Cc: alan, linux-cris-kernel, linux-serial, linux-kernel,
Edwin van Vliet
Struct member dma_in_enabled was assigned twice in a row.
Signed-off-by: Edwin van Vliet <edwin@cheatah.nl>
---
drivers/tty/serial/crisv10.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c
index 225123b..0c55181 100644
--- a/drivers/tty/serial/crisv10.c
+++ b/drivers/tty/serial/crisv10.c
@@ -330,7 +330,6 @@ static struct e100_serial rs_table[] = {
.dma_in_irq_description = "serial 1 dma rec",
#else
.dma_in_enabled = 0,
- .dma_in_enabled = 0,
.dma_in_nbr = UINT_MAX,
.dma_in_irq_nbr = 0,
.dma_in_irq_flags = 0,
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drivers/tty/serial/crisv10: fix double assignment
2011-07-10 23:37 [PATCH] drivers/tty/serial/crisv10: fix double assignment Edwin van Vliet
@ 2011-07-10 23:39 ` Jesper Juhl
0 siblings, 0 replies; 2+ messages in thread
From: Jesper Juhl @ 2011-07-10 23:39 UTC (permalink / raw)
To: Edwin van Vliet
Cc: starvik, jesper.nilsson, alan, linux-cris-kernel, linux-serial,
linux-kernel
On Mon, 11 Jul 2011, Edwin van Vliet wrote:
> Struct member dma_in_enabled was assigned twice in a row.
>
> Signed-off-by: Edwin van Vliet <edwin@cheatah.nl>
> ---
> drivers/tty/serial/crisv10.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c
> index 225123b..0c55181 100644
> --- a/drivers/tty/serial/crisv10.c
> +++ b/drivers/tty/serial/crisv10.c
> @@ -330,7 +330,6 @@ static struct e100_serial rs_table[] = {
> .dma_in_irq_description = "serial 1 dma rec",
> #else
> .dma_in_enabled = 0,
> - .dma_in_enabled = 0,
> .dma_in_nbr = UINT_MAX,
> .dma_in_irq_nbr = 0,
> .dma_in_irq_flags = 0,
>
Looks correct to me.
Reviewed-by: Jesper Juhl <jj@chaosbits.net>
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-10 23:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-10 23:37 [PATCH] drivers/tty/serial/crisv10: fix double assignment Edwin van Vliet
2011-07-10 23:39 ` Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox