public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Jamie Iles <jamie@jamieiles.com>
To: linux-serial@vger.kernel.org
Cc: Jamie Iles <jamie@jamieiles.com>, Greg KH <greg@kroah.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH] tty: 8250_dw: fix build error for CONFIG_SERIAL_8250=m
Date: Wed, 24 Aug 2011 08:11:46 +0100	[thread overview]
Message-ID: <1314169906-12958-1-git-send-email-jamie@jamieiles.com> (raw)

Allow 8250_dw to be built as a module and export serial8250_handle_irq
so that 8250 can still be built as a module.  This prevents the
following build failure:

drivers/built-in.o: In function `dw8250_handle_irq':
8250_dw.c:(.text+0xcad9c): undefined reference to `serial8250_handle_irq'

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Greg KH <greg@kroah.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
 drivers/tty/serial/8250.c    |    1 +
 drivers/tty/serial/8250_dw.c |    5 +++++
 drivers/tty/serial/Kconfig   |    2 +-
 3 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/drivers/tty/serial/8250.c b/drivers/tty/serial/8250.c
index 6f594d2..435ce14 100644
--- a/drivers/tty/serial/8250.c
+++ b/drivers/tty/serial/8250.c
@@ -1588,6 +1588,7 @@ int serial8250_handle_irq(struct uart_port *port, unsigned int iir)
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(serial8250_handle_irq);
 
 static int serial8250_default_handle_irq(struct uart_port *port)
 {
diff --git a/drivers/tty/serial/8250_dw.c b/drivers/tty/serial/8250_dw.c
index e25782a..844d3a8 100644
--- a/drivers/tty/serial/8250_dw.c
+++ b/drivers/tty/serial/8250_dw.c
@@ -13,6 +13,7 @@
  * raised, the LCR needs to be rewritten and the uart status register read.
  */
 #include <linux/io.h>
+#include <linux/module.h>
 #include <linux/serial_8250.h>
 #include <linux/serial_core.h>
 #include <linux/serial_reg.h>
@@ -97,3 +98,7 @@ int serial8250_use_designware_io(struct uart_port *up)
 
 	return 0;
 }
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Jamie Iles");
+MODULE_DESCRIPTION("Synopsys DesignWare 8250 UART support");
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index d2d1cc2..1002e2e 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -268,7 +268,7 @@ config SERIAL_8250_RM9K
 	  If unsure, say N.
 
 config SERIAL_8250_DW
-	bool "Support for Synopsys DesignWare 8250 quirks"
+	tristate "Support for Synopsys DesignWare 8250 quirks"
 	depends on SERIAL_8250
 	help
 	  Selecting this option will enable handling of the extra features
-- 
1.7.4.4


             reply	other threads:[~2011-08-24  7:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24  7:11 Jamie Iles [this message]
2011-08-24 14:45 ` [PATCH] tty: 8250_dw: fix build error for CONFIG_SERIAL_8250=m Arnd Bergmann
2011-08-24 14:54   ` Jamie Iles
2011-08-24 15:09     ` Greg KH
2011-08-24 15:12       ` Jamie Iles
2011-08-24 15:24   ` Jamie Iles
2011-08-24 16:14     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314169906-12958-1-git-send-email-jamie@jamieiles.com \
    --to=jamie@jamieiles.com \
    --cc=arnd@arndb.de \
    --cc=greg@kroah.com \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox