* [PATCH] jsm: Fixed EEH recovery error
@ 2011-10-03 16:52 Lucas Kannebley Tavares
0 siblings, 0 replies; 6+ messages in thread
From: Lucas Kannebley Tavares @ 2011-10-03 16:52 UTC (permalink / raw)
To: linux-serial
Cc: Breno Leitao, Alan Cox, linux-kernel, cascardo,
Lucas Kannebley Tavares
There was an error on the jsm driver that would cause it to be unable to
recover after a second error is detected.
At the first error, the device recovers properly:
[72521.485691] EEH: Detected PCI bus error on device 0003:02:00.0
[72521.485695] EEH: This PCI device has failed 1 times in the last hour:
...
[72532.035693] ttyn3 at MMIO 0x0 (irq = 49) is a jsm
[72532.105689] jsm: Port 3 added
However, at the second error, it cascades until EEH disables the device:
[72631.229549] Call Trace:
...
[72641.725687] jsm: Port 3 added
[72641.725695] EEH: Detected PCI bus error on device 0003:02:00.0
[72641.725698] EEH: This PCI device has failed 3 times in the last hour:
It was caused because the PCI state was not being saved after the first
restore. Therefore, at the second recovery the PCI state would not be
restored.
Signed-off-by: Lucas Kannebley Tavares <lucaskt@linux.vnet.ibm.com>
---
drivers/tty/serial/jsm/jsm_driver.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/jsm/jsm_driver.c b/drivers/tty/serial/jsm/jsm_driver.c
index 96da178..8941b15 100644
--- a/drivers/tty/serial/jsm/jsm_driver.c
+++ b/drivers/tty/serial/jsm/jsm_driver.c
@@ -270,6 +270,7 @@ static void jsm_io_resume(struct pci_dev *pdev)
struct jsm_board *brd = pci_get_drvdata(pdev);
pci_restore_state(pdev);
+ pci_save_state(pdev);
jsm_uart_port_init(brd);
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] jsm: Fixed EEH recovery error
@ 2012-01-09 12:58 Lucas Kannebley Tavares
0 siblings, 0 replies; 6+ messages in thread
From: Lucas Kannebley Tavares @ 2012-01-09 12:58 UTC (permalink / raw)
To: Greg KH
Cc: Thadeu Lima de Souza Cascardo, Breno Leitao, Alan Cox,
linux-serial, linux-kernel, Breno Leitao
There was an error on the jsm driver that would cause it to be unable to
recover after a second error is detected.
At the first error, the device recovers properly:
[72521.485691] EEH: Detected PCI bus error on device 0003:02:00.0
[72521.485695] EEH: This PCI device has failed 1 times in the last hour:
...
[72532.035693] ttyn3 at MMIO 0x0 (irq = 49) is a jsm
[72532.105689] jsm: Port 3 added
However, at the second error, it cascades until EEH disables the device:
[72631.229549] Call Trace:
...
[72641.725687] jsm: Port 3 added
[72641.725695] EEH: Detected PCI bus error on device 0003:02:00.0
[72641.725698] EEH: This PCI device has failed 3 times in the last hour:
It was caused because the PCI state was not being saved after the first
restore. Therefore, at the second recovery the PCI state would not be
restored.
Signed-off-by: Lucas Kannebley Tavares <lucaskt@linux.vnet.ibm.com>
Signed-off-by: Breno Leitao <brenohl@br.ibm.com>
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
---
drivers/tty/serial/jsm/jsm_driver.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/jsm/jsm_driver.c b/drivers/tty/serial/jsm/jsm_driver.c
index 7c867a0..7545fe1 100644
--- a/drivers/tty/serial/jsm/jsm_driver.c
+++ b/drivers/tty/serial/jsm/jsm_driver.c
@@ -251,6 +251,7 @@ static void jsm_io_resume(struct pci_dev *pdev)
struct jsm_board *brd = pci_get_drvdata(pdev);
pci_restore_state(pdev);
+ pci_save_state(pdev);
jsm_uart_port_init(brd);
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1315834565-9280-1-git-send-email-lucaskt@linux.vnet.ibm.com>]
* Re: [PATCH] jsm: Fixed EEH recovery error
[not found] <1315834565-9280-1-git-send-email-lucaskt@linux.vnet.ibm.com>
@ 2011-09-12 15:31 ` Breno Leitao
2011-09-12 15:35 ` Thadeu Lima de Souza Cascardo
1 sibling, 0 replies; 6+ messages in thread
From: Breno Leitao @ 2011-09-12 15:31 UTC (permalink / raw)
To: Lucas Kannebley Tavares
Cc: Thadeu Lima De Souza Cascardo, Alan Cox, linux-serial,
linux-kernel
On 09/12/2011 10:36 AM, Lucas Kannebley Tavares wrote:
> There was an error on the jsm driver that would cause it to be unable to
> recover after a second error is detected.
>
> At the first error, the device recovers properly:
>
> [72521.485691] EEH: Detected PCI bus error on device 0003:02:00.0
> [72521.485695] EEH: This PCI device has failed 1 times in the last hour:
> ...
> [72532.035693] ttyn3 at MMIO 0x0 (irq = 49) is a jsm
> [72532.105689] jsm: Port 3 added
>
> However, at the second error, it cascades until EEH disables the device:
>
> [72631.229549] Call Trace:
> ...
> [72641.725687] jsm: Port 3 added
> [72641.725695] EEH: Detected PCI bus error on device 0003:02:00.0
> [72641.725698] EEH: This PCI device has failed 3 times in the last hour:
>
> It was caused because the PCI state was not being saved after the first
> restore. Therefore, at the second recovery the PCI state would not be
> restored.
>
> Signed-off-by: Lucas Kannebley Tavares<lucaskt@linux.vnet.ibm.com>
Signed-off-by: Breno Leitao <brenohl@br.ibm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] jsm: Fixed EEH recovery error
[not found] <1315834565-9280-1-git-send-email-lucaskt@linux.vnet.ibm.com>
2011-09-12 15:31 ` Breno Leitao
@ 2011-09-12 15:35 ` Thadeu Lima de Souza Cascardo
2012-01-06 20:43 ` Lucas Kannebley Tavares
1 sibling, 1 reply; 6+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2011-09-12 15:35 UTC (permalink / raw)
To: Lucas Kannebley Tavares
Cc: Breno Leitao, Alan Cox, linux-serial, linux-kernel
On Mon, Sep 12, 2011 at 10:36:05AM -0300, Lucas Kannebley Tavares wrote:
> There was an error on the jsm driver that would cause it to be unable to
> recover after a second error is detected.
>
> At the first error, the device recovers properly:
>
> [72521.485691] EEH: Detected PCI bus error on device 0003:02:00.0
> [72521.485695] EEH: This PCI device has failed 1 times in the last hour:
> ...
> [72532.035693] ttyn3 at MMIO 0x0 (irq = 49) is a jsm
> [72532.105689] jsm: Port 3 added
>
> However, at the second error, it cascades until EEH disables the device:
>
> [72631.229549] Call Trace:
> ...
> [72641.725687] jsm: Port 3 added
> [72641.725695] EEH: Detected PCI bus error on device 0003:02:00.0
> [72641.725698] EEH: This PCI device has failed 3 times in the last hour:
>
> It was caused because the PCI state was not being saved after the first
> restore. Therefore, at the second recovery the PCI state would not be
> restored.
>
> Signed-off-by: Lucas Kannebley Tavares <lucaskt@linux.vnet.ibm.com>
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
> ---
> drivers/tty/serial/jsm/jsm_driver.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/tty/serial/jsm/jsm_driver.c b/drivers/tty/serial/jsm/jsm_driver.c
> index 96da178..8941b15 100644
> --- a/drivers/tty/serial/jsm/jsm_driver.c
> +++ b/drivers/tty/serial/jsm/jsm_driver.c
> @@ -270,6 +270,7 @@ static void jsm_io_resume(struct pci_dev *pdev)
> struct jsm_board *brd = pci_get_drvdata(pdev);
>
> pci_restore_state(pdev);
> + pci_save_state(pdev);
>
> jsm_uart_port_init(brd);
> }
> --
> 1.7.4.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] jsm: Fixed EEH recovery error
2011-09-12 15:35 ` Thadeu Lima de Souza Cascardo
@ 2012-01-06 20:43 ` Lucas Kannebley Tavares
2012-01-06 21:04 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Lucas Kannebley Tavares @ 2012-01-06 20:43 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo
Cc: Breno Leitao, Alan Cox, linux-serial, linux-kernel, Greg KH
On 09/12/2011 12:35 PM, Thadeu Lima de Souza Cascardo wrote:
> On Mon, Sep 12, 2011 at 10:36:05AM -0300, Lucas Kannebley Tavares wrote:
>> There was an error on the jsm driver that would cause it to be unable to
>> recover after a second error is detected.
>>
>> At the first error, the device recovers properly:
>>
>> [72521.485691] EEH: Detected PCI bus error on device 0003:02:00.0
>> [72521.485695] EEH: This PCI device has failed 1 times in the last hour:
>> ...
>> [72532.035693] ttyn3 at MMIO 0x0 (irq = 49) is a jsm
>> [72532.105689] jsm: Port 3 added
>>
>> However, at the second error, it cascades until EEH disables the device:
>>
>> [72631.229549] Call Trace:
>> ...
>> [72641.725687] jsm: Port 3 added
>> [72641.725695] EEH: Detected PCI bus error on device 0003:02:00.0
>> [72641.725698] EEH: This PCI device has failed 3 times in the last hour:
>>
>> It was caused because the PCI state was not being saved after the first
>> restore. Therefore, at the second recovery the PCI state would not be
>> restored.
>>
>> Signed-off-by: Lucas Kannebley Tavares<lucaskt@linux.vnet.ibm.com>
>Signed-off-by: Breno Leitao <brenohl@br.ibm.com>
> Acked-by: Thadeu Lima de Souza Cascardo<cascardo@linux.vnet.ibm.com>
Adding Greg to the CC list. It wasn't added earlier because
get_maintainers.pl only listed Alan's name. I apologize for the delay.
This is a bugfix to EEH handling on jsm.
>
>> ---
>> drivers/tty/serial/jsm/jsm_driver.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/tty/serial/jsm/jsm_driver.c b/drivers/tty/serial/jsm/jsm_driver.c
>> index 96da178..8941b15 100644
>> --- a/drivers/tty/serial/jsm/jsm_driver.c
>> +++ b/drivers/tty/serial/jsm/jsm_driver.c
>> @@ -270,6 +270,7 @@ static void jsm_io_resume(struct pci_dev *pdev)
>> struct jsm_board *brd = pci_get_drvdata(pdev);
>>
>> pci_restore_state(pdev);
>> + pci_save_state(pdev);
>>
>> jsm_uart_port_init(brd);
>> }
>> --
>> 1.7.4.4
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] jsm: Fixed EEH recovery error
2012-01-06 20:43 ` Lucas Kannebley Tavares
@ 2012-01-06 21:04 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2012-01-06 21:04 UTC (permalink / raw)
To: Lucas Kannebley Tavares
Cc: Thadeu Lima de Souza Cascardo, Breno Leitao, Alan Cox,
linux-serial, linux-kernel
On Fri, Jan 06, 2012 at 06:43:46PM -0200, Lucas Kannebley Tavares wrote:
>
> On 09/12/2011 12:35 PM, Thadeu Lima de Souza Cascardo wrote:
> >On Mon, Sep 12, 2011 at 10:36:05AM -0300, Lucas Kannebley Tavares wrote:
> >>There was an error on the jsm driver that would cause it to be unable to
> >>recover after a second error is detected.
> >>
> >>At the first error, the device recovers properly:
> >>
> >>[72521.485691] EEH: Detected PCI bus error on device 0003:02:00.0
> >>[72521.485695] EEH: This PCI device has failed 1 times in the last hour:
> >>...
> >>[72532.035693] ttyn3 at MMIO 0x0 (irq = 49) is a jsm
> >>[72532.105689] jsm: Port 3 added
> >>
> >>However, at the second error, it cascades until EEH disables the device:
> >>
> >>[72631.229549] Call Trace:
> >>...
> >>[72641.725687] jsm: Port 3 added
> >>[72641.725695] EEH: Detected PCI bus error on device 0003:02:00.0
> >>[72641.725698] EEH: This PCI device has failed 3 times in the last hour:
> >>
> >>It was caused because the PCI state was not being saved after the first
> >>restore. Therefore, at the second recovery the PCI state would not be
> >>restored.
> >>
> >>Signed-off-by: Lucas Kannebley Tavares<lucaskt@linux.vnet.ibm.com>
> >Signed-off-by: Breno Leitao <brenohl@br.ibm.com>
> >Acked-by: Thadeu Lima de Souza Cascardo<cascardo@linux.vnet.ibm.com>
>
> Adding Greg to the CC list. It wasn't added earlier because
> get_maintainers.pl only listed Alan's name. I apologize for the
> delay.
>
> This is a bugfix to EEH handling on jsm.
Can someone send me a patch in a format that I could actually apply it
in?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-01-09 12:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-03 16:52 [PATCH] jsm: Fixed EEH recovery error Lucas Kannebley Tavares
-- strict thread matches above, loose matches on Subject: below --
2012-01-09 12:58 Lucas Kannebley Tavares
[not found] <1315834565-9280-1-git-send-email-lucaskt@linux.vnet.ibm.com>
2011-09-12 15:31 ` Breno Leitao
2011-09-12 15:35 ` Thadeu Lima de Souza Cascardo
2012-01-06 20:43 ` Lucas Kannebley Tavares
2012-01-06 21:04 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).