From: Wolfram Sang <w.sang@pengutronix.de>
To: linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>,
Alan Cox <alan@linux.intel.com>,
Claudio Scordino <claudio@evidence.eu.com>,
Wolfram Sang <w.sang@pengutronix.de>
Subject: [PATCH RESEND 8/8] serial: 8250: fix comment about accessing EMSR
Date: Fri, 9 Dec 2011 18:07:20 +0100 [thread overview]
Message-ID: <1323450440-414-9-git-send-email-w.sang@pengutronix.de> (raw)
In-Reply-To: <1323450440-414-1-git-send-email-w.sang@pengutronix.de>
All docs I checked do say LCR should NOT be 0xBF (16c850, 16c854,
16v2750). Fix it according to that, since the only usage of the register
currently implements the revised access method. If somebody later finds
a derivate which actually does need 0xBF to enable that register, we can
update the comment again with precise references.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---
include/linux/serial_reg.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/serial_reg.h b/include/linux/serial_reg.h
index 0267bab6..0a1beca 100644
--- a/include/linux/serial_reg.h
+++ b/include/linux/serial_reg.h
@@ -211,7 +211,7 @@
#define UART_FCTR_TX 0x80 /* Programmable trigger mode select */
/*
- * LCR=0xBF, FCTR[6]=1
+ * LCR!=0xBF (some docs say =0), FCTR[6]=1, XR16C85x
*/
#define UART_EMSR 7 /* Extended Mode Select Register */
#define UART_EMSR_FIFO_COUNT 0x01 /* Rx/Tx select */
--
1.7.7.3
next prev parent reply other threads:[~2011-12-09 17:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 17:07 [PATCH RESEND 0/8] serial: 8250: support hw-based RS485 direction control Wolfram Sang
2011-12-09 17:07 ` [PATCH RESEND 1/8] serial: 8250: replace hardcoded 0xbf with #define Wolfram Sang
2011-12-09 18:58 ` Alan Cox
2011-12-09 17:07 ` [PATCH RESEND 2/8] serial: 8250: Add ioctl to enable auto rs485 mode with some Exar UARTs Wolfram Sang
2011-12-09 19:00 ` Alan Cox
2011-12-09 17:07 ` [PATCH RESEND 3/8] serial: 8250: save rs485_flags per instance Wolfram Sang
2011-12-09 19:10 ` Alan Cox
2011-12-09 17:07 ` [PATCH RESEND 4/8] serial: 8250: add RX_DURING_TX capability to RS485 mode Wolfram Sang
2011-12-09 17:07 ` [PATCH RESEND 5/8] serial: 8250: reject delaying RTS with RS485 Wolfram Sang
2011-12-09 17:07 ` [PATCH RESEND 6/8] serial: 8250: update rs485 flags with polarity settings Wolfram Sang
2011-12-09 19:13 ` Alan Cox
2011-12-09 17:07 ` [PATCH RESEND 7/8] serial: 8250: add Exar 16V2750 support Wolfram Sang
2011-12-09 17:07 ` Wolfram Sang [this message]
2011-12-12 14:42 ` [PATCH RESEND 0/8] serial: 8250: support hw-based RS485 direction control Claudio Scordino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323450440-414-9-git-send-email-w.sang@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=alan@linux.intel.com \
--cc=claudio@evidence.eu.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).