* [PATCH] serial: driver for m32 arch should not have DEC alpha errata
@ 2012-01-04 20:16 Paul Gortmaker
2012-01-05 0:36 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2012-01-04 20:16 UTC (permalink / raw)
To: alan, gregkh; +Cc: linux-serial, linux-kernel
This driver was copied from the original 8250 driver and hence
got the DEC alpha errata workaround. But the workaround is ugly
and we don't really want it in any more places than it absolutely
needs to be. Obviously ARCH=m32r means ARCH != alpha, so just
remove the references to the ALPHA_KLUDGE_MCR define.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
diff --git a/drivers/tty/serial/m32r_sio.c b/drivers/tty/serial/m32r_sio.c
index 0801893..94a6792 100644
--- a/drivers/tty/serial/m32r_sio.c
+++ b/drivers/tty/serial/m32r_sio.c
@@ -1000,11 +1000,8 @@ static void __init m32r_sio_register_ports(struct uart_driver *drv)
init_timer(&up->timer);
up->timer.function = m32r_sio_timeout;
- /*
- * ALPHA_KLUDGE_MCR needs to be killed.
- */
- up->mcr_mask = ~ALPHA_KLUDGE_MCR;
- up->mcr_force = ALPHA_KLUDGE_MCR;
+ up->mcr_mask = ~0;
+ up->mcr_force = 0;
uart_add_one_port(drv, &up->port);
}
--
1.7.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: driver for m32 arch should not have DEC alpha errata
2012-01-04 20:16 [PATCH] serial: driver for m32 arch should not have DEC alpha errata Paul Gortmaker
@ 2012-01-05 0:36 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2012-01-05 0:36 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: gregkh, linux-serial, linux-kernel
On Wed, 4 Jan 2012 15:16:24 -0500
Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> This driver was copied from the original 8250 driver and hence
> got the DEC alpha errata workaround. But the workaround is ugly
> and we don't really want it in any more places than it absolutely
> needs to be. Obviously ARCH=m32r means ARCH != alpha, so just
> remove the references to the ALPHA_KLUDGE_MCR define.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Alan Cox <alan@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-05 0:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-04 20:16 [PATCH] serial: driver for m32 arch should not have DEC alpha errata Paul Gortmaker
2012-01-05 0:36 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).