From: Shubhrajyoti D <shubhrajyoti@ti.com>
To: linux-serial@vger.kernel.org
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Shubhrajyoti D <shubhrajyoti@ti.com>,
"Govindraj.R" <govindraj.raja@ti.com>
Subject: [PATCH RFC] OMAP: serial: Release the claimed memory region in remove
Date: Fri, 10 Feb 2012 11:28:02 +0530 [thread overview]
Message-ID: <1328853482-3687-1-git-send-email-shubhrajyoti@ti.com> (raw)
Currently the memory region is not released the folowing error is
observed.
/testsuites # insmod omap-serial.ko
[ 130.746917] omap_uart omap_uart.0: memory region already claimed
[ 130.753143] omap_uart: probe of omap_uart.0 failed with error -16
[ 130.759338] omap_uart omap_uart.1: memory region already claimed
[ 130.765380] omap_uart: probe of omap_uart.1 failed with error -16
[ 130.771606] omap_uart omap_uart.2: memory region already claimed
[ 130.777679] omap_uart: probe of omap_uart.2 failed with error -16
[ 130.783905] omap_uart omap_uart.3: memory region already claimed
[ 130.789947] omap_uart: probe of omap_uart.3 failed with error -16
Fix it by releasing the memory region.
Cc: Govindraj.R <govindraj.raja@ti.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/tty/serial/omap-serial.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 130f7f8..4def6c3 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -1480,6 +1480,10 @@ do_release_region:
static int serial_omap_remove(struct platform_device *dev)
{
struct uart_omap_port *up = platform_get_drvdata(dev);
+ struct resource *r;
+
+ r = platform_get_resource(dev, IORESOURCE_MEM, 0);
+ release_mem_region(r->start, resource_size(r));
if (up) {
iounmap(up->port.membase);
--
1.7.1
next reply other threads:[~2012-02-10 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 5:58 Shubhrajyoti D [this message]
2012-02-10 15:23 ` [PATCH RFC] OMAP: serial: Release the claimed memory region in remove Menon, Nishanth
2012-02-10 18:01 ` Datta, Shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328853482-3687-1-git-send-email-shubhrajyoti@ti.com \
--to=shubhrajyoti@ti.com \
--cc=govindraj.raja@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox