From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: alan@linux.intel.com, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH 5/7] serial: remove back and forth conversions in serial_out_sync
Date: Thu, 1 Mar 2012 21:33:21 -0500 [thread overview]
Message-ID: <1330655603-5268-6-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1330655603-5268-1-git-send-email-paul.gortmaker@windriver.com>
The two callers to serial_out_sync() have a struct port right
there in scope, but then pass in a struct 8250_port which then
is locally resolved to a struct port.
Delete the needless back and forth and just pass in the struct
port directly.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/tty/serial/8250/8250.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
index 6945d96..d395f0e 100644
--- a/drivers/tty/serial/8250/8250.c
+++ b/drivers/tty/serial/8250/8250.c
@@ -475,9 +475,8 @@ static void set_io_from_upio(struct uart_port *p)
}
static void
-serial_out_sync(struct uart_8250_port *up, int offset, int value)
+serial_out_sync(struct uart_port *p, int offset, int value)
{
- struct uart_port *p = &up->port;
switch (p->iotype) {
case UPIO_MEM:
case UPIO_MEM32:
@@ -2034,11 +2033,11 @@ static int serial8250_startup(struct uart_port *port)
disable_irq_nosync(port->irq);
wait_for_xmitr(up, UART_LSR_THRE);
- serial_out_sync(up, UART_IER, UART_IER_THRI);
+ serial_out_sync(port, UART_IER, UART_IER_THRI);
udelay(1); /* allow THRE to set */
iir1 = serial_in(up, UART_IIR);
serial_out(up, UART_IER, 0);
- serial_out_sync(up, UART_IER, UART_IER_THRI);
+ serial_out_sync(port, UART_IER, UART_IER_THRI);
udelay(1); /* allow a working UART time to re-assert THRE */
iir = serial_in(up, UART_IIR);
serial_out(up, UART_IER, 0);
--
1.7.9.1
next prev parent reply other threads:[~2012-03-02 2:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 2:33 [RFC PATCH 0/7] serial: cleanups that strive to do nothing Paul Gortmaker
2012-03-02 2:33 ` [PATCH 1/7] serial: delete last unused traces of pausing I/O in 8250 Paul Gortmaker
2012-03-02 2:33 ` [PATCH 2/7] serial: make 8250's serial_in shareable to other drivers Paul Gortmaker
2012-03-02 2:33 ` [PATCH 3/7] serial: delete useless void casts in 8250.c Paul Gortmaker
2012-03-02 2:33 ` [PATCH 4/7] serial: reduce number of indirections in 8250 code Paul Gortmaker
2012-03-02 2:33 ` Paul Gortmaker [this message]
2012-03-02 11:22 ` [PATCH 5/7] serial: remove back and forth conversions in serial_out_sync Alan Cox
2012-03-02 14:13 ` Paul Gortmaker
2012-03-02 2:33 ` [PATCH 6/7] serial: introduce generic port in/out helpers Paul Gortmaker
2012-03-02 2:33 ` [PATCH 7/7] serial: use serial_port_in/out vs serial_in/out in 8250 Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330655603-5268-6-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).