From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: gregkh@linuxfoundation.org, alan@linux.intel.com
Cc: linux-serial@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH 3/7] serial: delete useless void casts in 8250.c
Date: Thu, 8 Mar 2012 19:12:10 -0500 [thread overview]
Message-ID: <1331251934-25540-4-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1331251934-25540-1-git-send-email-paul.gortmaker@windriver.com>
These might have worked some magic with an ancient gcc back in
1992, but "objdump --disassemble" on gcc 4.6 on x86-64 shows
identical output before and after this commit. Send the casts
and their hysterical rasins to the bitbucket.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/tty/serial/8250/8250.c | 22 +++++++++++-----------
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
index 4009e24..6a71716 100644
--- a/drivers/tty/serial/8250/8250.c
+++ b/drivers/tty/serial/8250/8250.c
@@ -1218,7 +1218,7 @@ static void autoconfig_irq(struct uart_8250_port *up)
ICP = (up->port.iobase & 0xfe0) | 0x1f;
save_ICP = inb_p(ICP);
outb_p(0x80, ICP);
- (void) inb_p(ICP);
+ inb_p(ICP);
}
/* forget possible initially masked and pending IRQ */
@@ -1238,10 +1238,10 @@ static void autoconfig_irq(struct uart_8250_port *up)
UART_MCR_DTR | UART_MCR_RTS | UART_MCR_OUT2);
}
serial_out(up, UART_IER, 0x0f); /* enable all intrs */
- (void)serial_in(up, UART_LSR);
- (void)serial_in(up, UART_RX);
- (void)serial_in(up, UART_IIR);
- (void)serial_in(up, UART_MSR);
+ serial_in(up, UART_LSR);
+ serial_in(up, UART_RX);
+ serial_in(up, UART_IIR);
+ serial_in(up, UART_MSR);
serial_out(up, UART_TX, 0xFF);
udelay(20);
irq = probe_irq_off(irqs);
@@ -1973,10 +1973,10 @@ static int serial8250_startup(struct uart_port *port)
/*
* Clear the interrupt registers.
*/
- (void) serial_in(up, UART_LSR);
- (void) serial_in(up, UART_RX);
- (void) serial_in(up, UART_IIR);
- (void) serial_in(up, UART_MSR);
+ serial_in(up, UART_LSR);
+ serial_in(up, UART_RX);
+ serial_in(up, UART_IIR);
+ serial_in(up, UART_MSR);
/*
* At this point, there's no way the LSR could still be 0xff;
@@ -2152,7 +2152,7 @@ dont_test_tx_en:
*/
icp = (up->port.iobase & 0xfe0) | 0x01f;
outb_p(0x80, icp);
- (void) inb_p(icp);
+ inb_p(icp);
}
return 0;
@@ -2198,7 +2198,7 @@ static void serial8250_shutdown(struct uart_port *port)
* Read data port to reset things, and then unlink from
* the IRQ chain.
*/
- (void) serial_in(up, UART_RX);
+ serial_in(up, UART_RX);
del_timer_sync(&up->timer);
up->timer.function = serial8250_timeout;
--
1.7.9.1
next prev parent reply other threads:[~2012-03-09 0:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 0:12 [PATCH v2 0/7] serial: cleanups that strive to do nothing Paul Gortmaker
2012-03-09 0:12 ` [PATCH 1/7] serial: delete last unused traces of pausing I/O in 8250 Paul Gortmaker
2012-03-09 0:12 ` [PATCH 2/7] serial: make 8250's serial_in shareable to other drivers Paul Gortmaker
2012-03-09 0:12 ` Paul Gortmaker [this message]
2012-03-09 0:12 ` [PATCH 4/7] serial: reduce number of indirections in 8250 code Paul Gortmaker
2012-03-09 0:12 ` [PATCH 5/7] serial: introduce generic port in/out helpers Paul Gortmaker
2012-03-09 0:12 ` [PATCH 6/7] serial: use serial_port_in/out vs serial_in/out in 8250 Paul Gortmaker
2012-03-09 0:12 ` [PATCH 7/7] serial: remove back and forth conversions in serial_out_sync Paul Gortmaker
2012-03-09 10:29 ` [PATCH v2 0/7] serial: cleanups that strive to do nothing Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2012-03-02 2:33 [RFC PATCH " Paul Gortmaker
2012-03-02 2:33 ` [PATCH 3/7] serial: delete useless void casts in 8250.c Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331251934-25540-4-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).