auto-RTS and TL16C754C

[grego rigolo <gregorigolo2002@yahoo.fr>]

Hi all,
I am using a TL16C754C in my design and i was wondering why the Auto-RTS was not enabled.
Indeed in the 8250.c source code we can read

FIXME:
         * - TI16C752 requires control thresholds to be set.
         * - UART_MCR_RTS is ineffective if auto-RTS mode is enabled

In the serial-omap.c, i saw that auto-rts had been enabled:
/* Hardware Flow Control Configuration */

    if (termios->c_cflag & CRTSCTS)
 {
        efr |= (UART_EFR_CTS | UART_EFR_RTS);
        serial_out(up, UART_LCR, UART_LCR_CONF_MODE_A);

        up->mcr = serial_in(up, UART_MCR);
        serial_out(up, UART_MCR, up->mcr | UART_MCR_TCRTLR);

        serial_out(up, UART_LCR, UART_LCR_CONF_MODE_B);
        up->efr = serial_in(up, UART_EFR);
        serial_out(up, UART_EFR, up->efr | UART_EFR_ECB);

        serial_out(up, UART_TI752_TCR, OMAP_UART_TCR_TRIG);
        serial_out(up, UART_EFR, efr); /* Enable AUTORTS and AUTOCTS */
        serial_out(up, UART_LCR, UART_LCR_CONF_MODE_A);
        serial_out(up,
 UART_MCR, up->mcr | UART_MCR_RTS);
        serial_out(up, UART_LCR, cval);


Thanks in advance for your comments

greg
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html