* [PATCH] serial: sc26xx: Fix compile breakage
@ 2012-08-01 8:00 Alexander Shiyan
2012-08-01 12:56 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Shiyan @ 2012-08-01 8:00 UTC (permalink / raw)
To: linux-serial; +Cc: Alan Cox, Greg Kroah-Hartman, Alexander Shiyan
This patch fixes the following compile breakage:
CC drivers/tty/serial/sc26xx.o
drivers/tty/serial/sc26xx.c: In function 'read_sc_port':
drivers/tty/serial/sc26xx.c:100: error: implicit declaration of function 'readb'
drivers/tty/serial/sc26xx.c: In function 'write_sc_port':
drivers/tty/serial/sc26xx.c:105: error: implicit declaration of function 'writeb'
drivers/tty/serial/sc26xx.c: In function 'sc26xx_probe':
drivers/tty/serial/sc26xx.c:652: error: implicit declaration of function 'ioremap_nocache'
drivers/tty/serial/sc26xx.c:652: warning: assignment makes pointer from integer without a cast
make[3]: *** [drivers/tty/serial/sc26xx.o] Error 1
make[2]: *** [drivers/tty/serial] Error 2
make[1]: *** [drivers/tty] Error 2
make: *** [drivers] Error 2
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
drivers/tty/serial/sc26xx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/sc26xx.c b/drivers/tty/serial/sc26xx.c
index e0b4b0a..3992e48 100644
--- a/drivers/tty/serial/sc26xx.c
+++ b/drivers/tty/serial/sc26xx.c
@@ -20,6 +20,7 @@
#include <linux/init.h>
#include <linux/platform_device.h>
#include <linux/irq.h>
+#include <linux/io.h>
#if defined(CONFIG_MAGIC_SYSRQ)
#define SUPPORT_SYSRQ
--
1.7.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: sc26xx: Fix compile breakage
2012-08-01 8:00 [PATCH] serial: sc26xx: Fix compile breakage Alexander Shiyan
@ 2012-08-01 12:56 ` Greg Kroah-Hartman
2012-08-01 14:55 ` Re[2]: " Alexander Shiyan
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2012-08-01 12:56 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: linux-serial, Alan Cox
On Wed, Aug 01, 2012 at 12:00:20PM +0400, Alexander Shiyan wrote:
> This patch fixes the following compile breakage:
>
> CC drivers/tty/serial/sc26xx.o
> drivers/tty/serial/sc26xx.c: In function 'read_sc_port':
> drivers/tty/serial/sc26xx.c:100: error: implicit declaration of function 'readb'
> drivers/tty/serial/sc26xx.c: In function 'write_sc_port':
> drivers/tty/serial/sc26xx.c:105: error: implicit declaration of function 'writeb'
> drivers/tty/serial/sc26xx.c: In function 'sc26xx_probe':
> drivers/tty/serial/sc26xx.c:652: error: implicit declaration of function 'ioremap_nocache'
> drivers/tty/serial/sc26xx.c:652: warning: assignment makes pointer from integer without a cast
> make[3]: *** [drivers/tty/serial/sc26xx.o] Error 1
> make[2]: *** [drivers/tty/serial] Error 2
> make[1]: *** [drivers/tty] Error 2
> make: *** [drivers] Error 2
Breakage in what tree? What caused this to break?
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re[2]: [PATCH] serial: sc26xx: Fix compile breakage
2012-08-01 12:56 ` Greg Kroah-Hartman
@ 2012-08-01 14:55 ` Alexander Shiyan
2012-08-01 15:04 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Shiyan @ 2012-08-01 14:55 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-serial, Alan Cox
Hello.
Wed, 1 Aug 2012 05:56:37 -0700 от Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Wed, Aug 01, 2012 at 12:00:20PM +0400, Alexander Shiyan wrote:
> > This patch fixes the following compile breakage:
> > CC drivers/tty/serial/sc26xx.o
> > drivers/tty/serial/sc26xx.c: In function 'read_sc_port':
> > drivers/tty/serial/sc26xx.c:100: error: implicit declaration of function 'readb'
> > drivers/tty/serial/sc26xx.c: In function 'write_sc_port':
> > drivers/tty/serial/sc26xx.c:105: error: implicit declaration of function 'writeb'
> > drivers/tty/serial/sc26xx.c: In function 'sc26xx_probe':
> > drivers/tty/serial/sc26xx.c:652: error: implicit declaration of function 'ioremap_nocache'
> > drivers/tty/serial/sc26xx.c:652: warning: assignment makes pointer from integer without a cast
> > make[3]: *** [drivers/tty/serial/sc26xx.o] Error 1
> > make[2]: *** [drivers/tty/serial] Error 2
> > make[1]: *** [drivers/tty] Error 2
> > make: *** [drivers] Error 2
>
> Breakage in what tree? What caused this to break?
Breakage due to missing header linux/io.h.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: sc26xx: Fix compile breakage
2012-08-01 14:55 ` Re[2]: " Alexander Shiyan
@ 2012-08-01 15:04 ` Greg Kroah-Hartman
2012-08-01 17:44 ` Alexander Shiyan
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2012-08-01 15:04 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: linux-serial, Alan Cox
On Wed, Aug 01, 2012 at 06:55:30PM +0400, Alexander Shiyan wrote:
> Hello.
>
> Wed, 1 Aug 2012 05:56:37 -0700 от Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> > On Wed, Aug 01, 2012 at 12:00:20PM +0400, Alexander Shiyan wrote:
> > > This patch fixes the following compile breakage:
> > > CC drivers/tty/serial/sc26xx.o
> > > drivers/tty/serial/sc26xx.c: In function 'read_sc_port':
> > > drivers/tty/serial/sc26xx.c:100: error: implicit declaration of function 'readb'
> > > drivers/tty/serial/sc26xx.c: In function 'write_sc_port':
> > > drivers/tty/serial/sc26xx.c:105: error: implicit declaration of function 'writeb'
> > > drivers/tty/serial/sc26xx.c: In function 'sc26xx_probe':
> > > drivers/tty/serial/sc26xx.c:652: error: implicit declaration of function 'ioremap_nocache'
> > > drivers/tty/serial/sc26xx.c:652: warning: assignment makes pointer from integer without a cast
> > > make[3]: *** [drivers/tty/serial/sc26xx.o] Error 1
> > > make[2]: *** [drivers/tty/serial] Error 2
> > > make[1]: *** [drivers/tty] Error 2
> > > make: *** [drivers] Error 2
> >
> > Breakage in what tree? What caused this to break?
> Breakage due to missing header linux/io.h.
Again, where did this break (3.4, 3.5, 3.6-rc1, 2.6.32, etc.) and what
caused it to break (what patch?)
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: sc26xx: Fix compile breakage
2012-08-01 15:04 ` Greg Kroah-Hartman
@ 2012-08-01 17:44 ` Alexander Shiyan
0 siblings, 0 replies; 5+ messages in thread
From: Alexander Shiyan @ 2012-08-01 17:44 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-serial, Alan Cox
On Wed, 1 Aug 2012 08:04:40 -0700
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Wed, Aug 01, 2012 at 06:55:30PM +0400, Alexander Shiyan wrote:
> > Wed, 1 Aug 2012 05:56:37 -0700 от Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> > > On Wed, Aug 01, 2012 at 12:00:20PM +0400, Alexander Shiyan wrote:
> > > > This patch fixes the following compile breakage:
> > > > CC drivers/tty/serial/sc26xx.o
> > > > drivers/tty/serial/sc26xx.c: In function 'read_sc_port':
> > > > drivers/tty/serial/sc26xx.c:100: error: implicit declaration of function 'readb'
> > > > drivers/tty/serial/sc26xx.c: In function 'write_sc_port':
> > > > drivers/tty/serial/sc26xx.c:105: error: implicit declaration of function 'writeb'
> > > > drivers/tty/serial/sc26xx.c: In function 'sc26xx_probe':
> > > > drivers/tty/serial/sc26xx.c:652: error: implicit declaration of function 'ioremap_nocache'
> > > > drivers/tty/serial/sc26xx.c:652: warning: assignment makes pointer from integer without a cast
> > > > make[3]: *** [drivers/tty/serial/sc26xx.o] Error 1
> > > > make[2]: *** [drivers/tty/serial] Error 2
> > > > make[1]: *** [drivers/tty] Error 2
> > > > make: *** [drivers] Error 2
> > >
> > > Breakage in what tree? What caused this to break?
> > Breakage due to missing header linux/io.h.
>
> Again, where did this break (3.4, 3.5, 3.6-rc1, 2.6.32, etc.) and what
> caused it to break (what patch?)
I'm using kernel 3.4.5. Perhaps, the problem not in header that missing, but is that I build
a driver for ARM platform, i.e. with a patched Makefile. In any case, you can just drop this
patch. I use these ICs with ARM architecture, and so I write an improved version of the driver
that will support all ICs from this series and do not depend on the architecture.
--
Alexander Shiyan <shc_work@mail.ru>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-01 17:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-01 8:00 [PATCH] serial: sc26xx: Fix compile breakage Alexander Shiyan
2012-08-01 12:56 ` Greg Kroah-Hartman
2012-08-01 14:55 ` Re[2]: " Alexander Shiyan
2012-08-01 15:04 ` Greg Kroah-Hartman
2012-08-01 17:44 ` Alexander Shiyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).