linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org,
	linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 0/1] staging: Add firewire-serial driver
Date: Wed, 24 Oct 2012 11:56:19 -0400	[thread overview]
Message-ID: <1351094179.8875.86.camel@thor> (raw)
In-Reply-To: <20121024154141.3029ad92@stein>

> > >  drivers/staging/fwserial/dma_fifo.c |  310 ++++
> > >  drivers/staging/fwserial/dma_fifo.h |  130 ++
> > >  drivers/staging/fwserial/fwserial.c | 2885 +++++++++++++++++++++++++++++++++++
> > >  drivers/staging/fwserial/fwserial.h |  355 +++++
> 
> drivers/firewire/net.c is 1721 lines, sbp_target is 2868 lines.
> Why is fwserial bigger?

1) Exclude the dma_fifo* files in the comparison, because block & net
devices get dma-able memory management from their subsystems.
2) Certain tty concepts don't map well to an automated bus, so these are
simulated (eg, break handling)
3) fwserial has to implement a protocol to virtually cable peers
4) sbp_target only supports 1 target.



  reply	other threads:[~2012-10-24 15:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1350565015.23730.4.camel@thor>
     [not found] ` <20121022224505.GD24489@kroah.com>
     [not found]   ` <1350959679.2621.55.camel@thor>
     [not found]     ` <20121023105140.5996c3a5@pyramind.ukuu.org.uk>
2012-10-23 16:30       ` [PATCH 0/1] staging: Add firewire-serial driver Peter Hurley
2012-10-23 18:41         ` Stefan Richter
2012-10-24 13:41   ` Stefan Richter
2012-10-24 15:56     ` Peter Hurley [this message]
2012-11-02 12:16 ` [PATCH v2 " Peter Hurley
2012-11-02 12:16   ` [PATCH v2 1/1] staging: fwserial: Add TTY-over-Firewire serial driver Peter Hurley
2012-11-12 23:33     ` Stefan Richter
2012-11-12 23:51       ` Greg Kroah-Hartman
2012-11-13 19:37         ` Peter Hurley
2012-11-13 19:47           ` Greg Kroah-Hartman
2012-11-13 19:14       ` Peter Hurley
2012-11-14  1:25         ` Stefan Richter
2012-11-27 18:33           ` Peter Hurley
2012-11-27 23:58             ` Stefan Richter
2012-11-28  1:00               ` Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351094179.8875.86.camel@thor \
    --to=peter@hurleysoftware.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).