From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH 0/1] staging: Add firewire-serial driver Date: Wed, 24 Oct 2012 11:56:19 -0400 Message-ID: <1351094179.8875.86.camel@thor> References: <1350565015.23730.4.camel@thor> <20121022224505.GD24489@kroah.com> <20121024154141.3029ad92@stein> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout39.mail01.mtsvc.net ([216.70.64.83]:44911 "EHLO n12.mail01.mtsvc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756985Ab2JXP40 (ORCPT ); Wed, 24 Oct 2012 11:56:26 -0400 In-Reply-To: <20121024154141.3029ad92@stein> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Stefan Richter Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org > > > drivers/staging/fwserial/dma_fifo.c | 310 ++++ > > > drivers/staging/fwserial/dma_fifo.h | 130 ++ > > > drivers/staging/fwserial/fwserial.c | 2885 +++++++++++++++++++++++++++++++++++ > > > drivers/staging/fwserial/fwserial.h | 355 +++++ > > drivers/firewire/net.c is 1721 lines, sbp_target is 2868 lines. > Why is fwserial bigger? 1) Exclude the dma_fifo* files in the comparison, because block & net devices get dma-able memory management from their subsystems. 2) Certain tty concepts don't map well to an automated bus, so these are simulated (eg, break handling) 3) fwserial has to implement a protocol to virtually cable peers 4) sbp_target only supports 1 target.