linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jun Chen <jun.d.chen@intel.com>
To: Alan Cox <alan@linux.intel.com>
Cc: serial <linux-serial@vger.kernel.org>,
	"russ.gorby" <russ.gorby@intel.com>,
	chao.bi@intel.com, jun.d.chen@intel.com
Subject: [PATCH] serial: ifx6x60: ifx_spi_write don't need to do mrdy_assert when fifo is not empty.
Date: Tue, 06 Nov 2012 04:28:54 -0500	[thread overview]
Message-ID: <1352194134.4332.47.camel@chenjun-workstation> (raw)


This patch check whether the kfifo lenth equal to the count of write data.If condition
is true,ifx_spi_write need to trigger one mrdy_assert. If condition is false,the mrdy_assert
will be triggered by the next ifx_spi_io.
Cc: Bi Chao <chao.bi@intel.com>
Signed-off-by: Chen Jun <jun.d.chen@intel.com>
---
 drivers/tty/serial/ifx6x60.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
index ac718e1..b52ef8d 100644
--- a/drivers/tty/serial/ifx6x60.c
+++ b/drivers/tty/serial/ifx6x60.c
@@ -522,7 +522,8 @@ static int ifx_spi_write(struct tty_struct *tty, const unsigned char *buf,
 	unsigned char *tmp_buf = (unsigned char *)buf;
 	int tx_count = kfifo_in_locked(&ifx_dev->tx_fifo, tmp_buf, count,
 				   &ifx_dev->fifo_lock);
-	mrdy_assert(ifx_dev);
+	if (kfifo_len(&ifx_dev->tx_fifo) == count)
+		mrdy_assert(ifx_dev);
 	return tx_count;
 }
 
-- 
1.7.4.1




             reply	other threads:[~2012-11-06  1:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06  9:28 Jun Chen [this message]
2012-11-06  9:47 ` [PATCH] serial: ifx6x60: ifx_spi_write don't need to do mrdy_assert when fifo is not empty Alan Cox
2012-11-07  9:09   ` Chen, Jun D
  -- strict thread matches above, loose matches on Subject: below --
2012-11-07 17:04 Jun Chen
2012-11-07  9:11 ` Alan Cox
2012-11-16 11:08 Jun Chen
2012-11-16 12:38 ` Greg KH
2012-11-18  3:14   ` Chen, Jun D
2012-11-18  3:30     ` Greg KH
2012-11-19 10:07 Jun Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352194134.4332.47.camel@chenjun-workstation \
    --to=jun.d.chen@intel.com \
    --cc=alan@linux.intel.com \
    --cc=chao.bi@intel.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=russ.gorby@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).