linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jun Chen <jun.d.chen@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Alan Cox <alan@linux.intel.com>, Bi Chao <chao.bi@intel.com>,
	Jun Chen <jun.d.chen@intel.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	serial <linux-serial@vger.kernel.org>
Subject: [PATCH] serial: ifx6x60: ifx_spi_write don't need to do mrdy_assert when fifo is not empty
Date: Mon, 19 Nov 2012 05:07:10 -0500	[thread overview]
Message-ID: <1353319630.23300.1.camel@chenjun-workstation> (raw)


This patch check whether the fifo lenth is empty before writing new data to fifo.If condition
is true,ifx_spi_write need to trigger one mrdy_assert. If condition is false,the mrdy_assert
will be trigger by the next ifx_spi_io.
Cc: Bi Chao <chao.bi@intel.com>
Signed-off-by: Chen Jun <jun.d.chen@intel.com>
---
 drivers/tty/serial/ifx6x60.c |   14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
index 5b9bc19..aa01989 100644
--- a/drivers/tty/serial/ifx6x60.c
+++ b/drivers/tty/serial/ifx6x60.c
@@ -469,9 +469,17 @@ static int ifx_spi_write(struct tty_struct *tty, const unsigned char *buf,
 {
 	struct ifx_spi_device *ifx_dev = tty->driver_data;
 	unsigned char *tmp_buf = (unsigned char *)buf;
-	int tx_count = kfifo_in_locked(&ifx_dev->tx_fifo, tmp_buf, count,
-				   &ifx_dev->fifo_lock);
-	mrdy_assert(ifx_dev);
+	int tx_count;
+	unsigned long flags;
+	bool is_fifo_empty;
+
+	spin_lock_irqsave(&ifx_dev->fifo_lock, flags);
+	is_fifo_empty = kfifo_is_empty(&ifx_dev->tx_fifo);
+	tx_count = kfifo_in(&ifx_dev->tx_fifo, tmp_buf, count);
+	spin_unlock_irqrestore(&ifx_dev->fifo_lock, flags);
+	if (is_fifo_empty)
+		mrdy_assert(ifx_dev);
+
 	return tx_count;
 }
 
-- 
1.7.4.1

             reply	other threads:[~2012-11-19 10:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 10:07 Jun Chen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-11-16 11:08 [PATCH] serial: ifx6x60: ifx_spi_write don't need to do mrdy_assert when fifo is not empty Jun Chen
2012-11-16 12:38 ` Greg KH
2012-11-18  3:14   ` Chen, Jun D
2012-11-18  3:30     ` Greg KH
2012-11-07 17:04 Jun Chen
2012-11-07  9:11 ` Alan Cox
2012-11-06  9:28 Jun Chen
2012-11-06  9:47 ` Alan Cox
2012-11-07  9:09   ` Chen, Jun D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353319630.23300.1.camel@chenjun-workstation \
    --to=jun.d.chen@intel.com \
    --cc=alan@linux.intel.com \
    --cc=chao.bi@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).