From: Yan Hong <clouds.yan@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org
Subject: [PATCH 2/2] tty: remove useless initialization in tty_open
Date: Fri, 23 Nov 2012 22:41:48 +0800 [thread overview]
Message-ID: <1353681708-5413-2-git-send-email-clouds.yan@gmail.com> (raw)
In-Reply-To: <1353681708-5413-1-git-send-email-clouds.yan@gmail.com>
retval must be zero here, no need to set it to zero explicitly.
Signed-off-by: Yan Hong <clouds.yan@gmail.com>
---
drivers/tty/tty_io.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index e278edf..6d90e9b 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1928,7 +1928,6 @@ retry_open:
noctty = filp->f_flags & O_NOCTTY;
index = -1;
- retval = 0;
mutex_lock(&tty_mutex);
/* This is protected by the tty_mutex */
--
1.7.9.5
next prev parent reply other threads:[~2012-11-23 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 14:41 [PATCH 1/2] tty: remove redundant initialization in initialize_tty_struct() Yan Hong
2012-11-23 14:41 ` Yan Hong [this message]
2012-11-23 14:51 ` Alan Cox
2012-11-23 15:04 ` Yan Hong
2012-12-20 15:55 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353681708-5413-2-git-send-email-clouds.yan@gmail.com \
--to=clouds.yan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).