From: Johan Hovold <jhovold@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-serial@vger.kernel.org,
Peter Hurley <peter@hurleysoftware.com>,
Johan Hovold <jhovold@gmail.com>
Subject: [PATCH v2 0/4] TTY: port hangup and close fixes
Date: Tue, 26 Feb 2013 12:14:28 +0100 [thread overview]
Message-ID: <1361877272-6074-1-git-send-email-jhovold@gmail.com> (raw)
These patches against tty-next fix a few issues with tty-port hangup and
close.
The first and third patch are essentially clean ups.
The second patch makes sure DTR is dropped also on hangup and that DTR
is only dropped for initialised ports (where is could have been raised
in the first place).
The fourth and final patch, make sure no tty callbacks are made from
tty_port_close_start when the port has not been initialised (successfully
opened). This was previously only done for wait_until_sent but there's
no reason to call flush_buffer or to honour port drain delay either.
The latter could cause a failed open to stall for up to two seconds.
As a side-effect, these patches also fix an issue in USB-serial where we could
get tty-port callbacks on an uninitialised port after having hung up and
unregistered a device after disconnect.
Johan
v2:
- reuse tty reference from hangup and close in shutdown. Both call sites
guarantee tty is either NULL or has a kref.
Changes since RFC-series:
- fix up the two driver relying on tty_port_close_start directly but
that did not manage DTR themselves
Johan Hovold (4):
TTY: clean up port shutdown
TTY: fix DTR not being dropped on hang up
TTY: clean up port drain-delay handling
TTY: fix close of uninitialised ports
drivers/tty/mxser.c | 4 +++
drivers/tty/n_gsm.c | 4 +++
drivers/tty/tty_port.c | 72 +++++++++++++++++++++++++++++---------------------
3 files changed, 50 insertions(+), 30 deletions(-)
--
1.8.1.1
next reply other threads:[~2013-02-26 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 11:14 Johan Hovold [this message]
2013-02-26 11:14 ` [PATCH v2 1/4] TTY: clean up port shutdown Johan Hovold
[not found] ` <1361877272-6074-1-git-send-email-jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-02-26 11:14 ` [PATCH v2 2/4] TTY: fix DTR not being dropped on hang up Johan Hovold
2013-02-26 11:14 ` [PATCH v2 3/4] TTY: clean up port drain-delay handling Johan Hovold
2013-02-26 11:14 ` [PATCH v2 4/4] TTY: fix close of uninitialised ports Johan Hovold
2013-02-26 11:56 ` [PATCH v2 0/4] TTY: port hangup and close fixes Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361877272-6074-1-git-send-email-jhovold@gmail.com \
--to=jhovold@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).