* [PATCH 1/1] serial: vt8500_serial: Convert to devm_ioremap_resource()
@ 2013-03-04 8:54 Sachin Kamat
2013-03-04 9:16 ` Thierry Reding
2013-03-04 17:09 ` Tony Prisk
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-03-04 8:54 UTC (permalink / raw)
To: linux-serial; +Cc: linux, gregkh, sachin.kamat, thierry.reding
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/tty/serial/vt8500_serial.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c
index a3f9dd5..f15f53f 100644
--- a/drivers/tty/serial/vt8500_serial.c
+++ b/drivers/tty/serial/vt8500_serial.c
@@ -35,6 +35,7 @@
#include <linux/clk.h>
#include <linux/platform_device.h>
#include <linux/of.h>
+#include <linux/err.h>
/*
* UART Register offsets
@@ -585,9 +586,9 @@ static int vt8500_serial_probe(struct platform_device *pdev)
if (!vt8500_port)
return -ENOMEM;
- vt8500_port->uart.membase = devm_request_and_ioremap(&pdev->dev, mmres);
- if (!vt8500_port->uart.membase)
- return -EADDRNOTAVAIL;
+ vt8500_port->uart.membase = devm_ioremap_resource(&pdev->dev, mmres);
+ if (IS_ERR(vt8500_port->uart.membase))
+ return PTR_ERR(vt8500_port->uart.membase);
vt8500_port->clk = of_clk_get(pdev->dev.of_node, 0);
if (IS_ERR(vt8500_port->clk)) {
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] serial: vt8500_serial: Convert to devm_ioremap_resource()
2013-03-04 8:54 [PATCH 1/1] serial: vt8500_serial: Convert to devm_ioremap_resource() Sachin Kamat
@ 2013-03-04 9:16 ` Thierry Reding
2013-03-04 17:09 ` Tony Prisk
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2013-03-04 9:16 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-serial, linux, gregkh
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
On Mon, Mar 04, 2013 at 02:24:39PM +0530, Sachin Kamat wrote:
> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/tty/serial/vt8500_serial.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] serial: vt8500_serial: Convert to devm_ioremap_resource()
2013-03-04 8:54 [PATCH 1/1] serial: vt8500_serial: Convert to devm_ioremap_resource() Sachin Kamat
2013-03-04 9:16 ` Thierry Reding
@ 2013-03-04 17:09 ` Tony Prisk
1 sibling, 0 replies; 3+ messages in thread
From: Tony Prisk @ 2013-03-04 17:09 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-serial, gregkh, thierry.reding
On Mon, 2013-03-04 at 14:24 +0530, Sachin Kamat wrote:
> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/tty/serial/vt8500_serial.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c
> index a3f9dd5..f15f53f 100644
> --- a/drivers/tty/serial/vt8500_serial.c
> +++ b/drivers/tty/serial/vt8500_serial.c
> @@ -35,6 +35,7 @@
> #include <linux/clk.h>
> #include <linux/platform_device.h>
> #include <linux/of.h>
> +#include <linux/err.h>
>
> /*
> * UART Register offsets
> @@ -585,9 +586,9 @@ static int vt8500_serial_probe(struct platform_device *pdev)
> if (!vt8500_port)
> return -ENOMEM;
>
> - vt8500_port->uart.membase = devm_request_and_ioremap(&pdev->dev, mmres);
> - if (!vt8500_port->uart.membase)
> - return -EADDRNOTAVAIL;
> + vt8500_port->uart.membase = devm_ioremap_resource(&pdev->dev, mmres);
> + if (IS_ERR(vt8500_port->uart.membase))
> + return PTR_ERR(vt8500_port->uart.membase);
>
> vt8500_port->clk = of_clk_get(pdev->dev.of_node, 0);
> if (IS_ERR(vt8500_port->clk)) {
Acked-by: Tony Prisk <linux@prisktech.co.nz>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-04 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-04 8:54 [PATCH 1/1] serial: vt8500_serial: Convert to devm_ioremap_resource() Sachin Kamat
2013-03-04 9:16 ` Thierry Reding
2013-03-04 17:09 ` Tony Prisk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).