From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Graeme Russ <graeme.russ@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-serial@vger.kernel.org, Tom Rini <trini@ti.com>,
Vadim Bendebury <vbendeb@chromium.org>
Subject: [PATCH v6 28/31] serial: ns16550: Remove unwanted cast
Date: Tue, 5 Mar 2013 16:40:02 -0800 [thread overview]
Message-ID: <1362530405-10824-29-git-send-email-sjg@chromium.org> (raw)
In-Reply-To: <1362530405-10824-1-git-send-email-sjg@chromium.org>
This cast does not seem correct, since we should be writing to a pointer,
not a ulong.
This fixes the following warning on nds32:
-ns16550.c:49: warning: passing argument 2 of 'writeb' makes pointer from integer without a cast
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v6:
- Add new patch to fix up ns16550 cast
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/serial/ns16550.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 87a0917..b2da8b3 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -46,7 +46,7 @@ void NS16550_init(NS16550_t com_port, int baud_divisor)
defined(CONFIG_AM33XX)
serial_out(0x7, &com_port->mdr1); /* mode select reset TL16C750*/
#endif
- serial_out(UART_LCR_BKSE | UART_LCRVAL, (ulong)&com_port->lcr);
+ serial_out(UART_LCR_BKSE | UART_LCRVAL, &com_port->lcr);
serial_out(0, &com_port->dll);
serial_out(0, &com_port->dlm);
serial_out(UART_LCRVAL, &com_port->lcr);
--
1.8.1.3
prev parent reply other threads:[~2013-03-06 0:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 0:39 [PATCH v6 0/31] Create generic board init for ARM, x86, PPC Simon Glass
2013-03-06 0:40 ` Simon Glass [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362530405-10824-29-git-send-email-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=graeme.russ@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-serial@vger.kernel.org \
--cc=trini@ti.com \
--cc=u-boot@lists.denx.de \
--cc=vbendeb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).