From: Johan Hovold <jhovold@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
Peter Hurley <peter@hurleysoftware.com>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, Johan Hovold <jhovold@gmail.com>
Subject: [PATCH v3 5/6] TTY: clean up port drain-delay handling
Date: Thu, 7 Mar 2013 15:55:52 +0100 [thread overview]
Message-ID: <1362668153-10972-6-git-send-email-jhovold@gmail.com> (raw)
In-Reply-To: <1362668153-10972-1-git-send-email-jhovold@gmail.com>
Move port drain-delay handling to a separate function.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
drivers/tty/tty_port.c | 27 ++++++++++++++++-----------
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
index cd65f7e..048cc85 100644
--- a/drivers/tty/tty_port.c
+++ b/drivers/tty/tty_port.c
@@ -408,6 +408,20 @@ int tty_port_block_til_ready(struct tty_port *port,
}
EXPORT_SYMBOL(tty_port_block_til_ready);
+static void tty_port_drain_delay(struct tty_port *port, struct tty_struct *tty)
+{
+ unsigned int bps = tty_get_baud_rate(tty);
+ long timeout;
+
+ if (bps > 1200) {
+ timeout = (HZ * 10 * port->drain_delay) / bps;
+ timeout = max_t(long, timeout, HZ / 10);
+ } else {
+ timeout = 2 * HZ;
+ }
+ schedule_timeout_interruptible(timeout);
+}
+
int tty_port_close_start(struct tty_port *port,
struct tty_struct *tty, struct file *filp)
{
@@ -446,17 +460,8 @@ int tty_port_close_start(struct tty_port *port,
if (test_bit(ASYNCB_INITIALIZED, &port->flags) &&
port->closing_wait != ASYNC_CLOSING_WAIT_NONE)
tty_wait_until_sent_from_close(tty, port->closing_wait);
- if (port->drain_delay) {
- unsigned int bps = tty_get_baud_rate(tty);
- long timeout;
-
- if (bps > 1200)
- timeout = max_t(long,
- (HZ * 10 * port->drain_delay) / bps, HZ / 10);
- else
- timeout = 2 * HZ;
- schedule_timeout_interruptible(timeout);
- }
+ if (port->drain_delay)
+ tty_port_drain_delay(port, tty);
/* Flush the ldisc buffering */
tty_ldisc_flush(tty);
--
1.8.1.1
next prev parent reply other threads:[~2013-03-07 14:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1362085054.3337.20.camel@thor.lan>
2013-03-05 16:02 ` [Fwd: [PATCH v2 0/4] TTY: port hangup and close fixes] Jiri Slaby
2013-03-05 17:06 ` Peter Hurley
[not found] ` <1362503170.18799.33.camel-AsKIXgLx6sE@public.gmane.org>
2013-03-05 21:56 ` Jiri Slaby
2013-03-05 22:02 ` Peter Hurley
2013-03-05 22:10 ` Jiri Slaby
2013-03-05 22:32 ` Peter Hurley
2013-03-06 16:23 ` Jiri Slaby
2013-03-06 16:52 ` Johan Hovold
2013-03-06 19:14 ` Peter Hurley
[not found] ` <1362597296.18799.198.camel-AsKIXgLx6sE@public.gmane.org>
2013-03-07 9:43 ` Johan Hovold
2013-03-07 21:52 ` Peter Hurley
[not found] ` <51361724.4050107-AlSwsSmVLrQ@public.gmane.org>
2013-03-07 14:55 ` [PATCH v3 0/6] TTY: port hangup and close fixes Johan Hovold
[not found] ` <1362668153-10972-1-git-send-email-jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-07 14:55 ` [PATCH v3 1/6] TTY: clean up port shutdown Johan Hovold
2013-03-07 14:55 ` [PATCH v3 2/6] TTY: wake up processes last at hangup Johan Hovold
2013-03-07 14:55 ` [PATCH v3 3/6] TTY: fix DTR being raised on hang up Johan Hovold
2013-03-13 19:43 ` Peter Hurley
[not found] ` <1363203823.25976.102.camel-AsKIXgLx6sE@public.gmane.org>
2013-03-15 9:24 ` Johan Hovold
2013-03-15 11:03 ` Peter Hurley
2013-03-15 11:30 ` Johan Hovold
2013-03-15 11:57 ` Peter Hurley
2013-03-07 14:55 ` [PATCH v3 4/6] TTY: fix DTR not being dropped " Johan Hovold
2013-03-07 14:55 ` Johan Hovold [this message]
2013-03-07 14:55 ` [PATCH v3 6/6] TTY: fix close of uninitialised ports Johan Hovold
2013-03-13 19:50 ` [PATCH v3 0/6] TTY: port hangup and close fixes Peter Hurley
2013-03-15 9:29 ` Johan Hovold
2013-03-15 19:05 ` Greg Kroah-Hartman
2013-03-15 19:42 ` Johan Hovold
2013-03-18 23:28 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362668153-10972-6-git-send-email-jhovold@gmail.com \
--to=jhovold@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).