From: Philippe Langlais <philippe.langlais@st.com>
To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Hans-Peter Oeri <hp@oeri.ch>,
Philippe Langlais <philippe.langlais@st.com>
Subject: [PATCH] tty: serial: 8250: remove U6715 16550A auto-detection
Date: Tue, 19 Mar 2013 20:50:09 +0100 [thread overview]
Message-ID: <1363722609-20021-1-git-send-email-philippe.langlais@st.com> (raw)
The auto-detection based on 64 bytes fifo size causes troubles
for the identification of the MultiTechZPX Modems (pci 11c1:0480).
They loose the ability to do hardware flow control
(specifically CTS is never set).
Signed-off-by: Philippe Langlais <philippe.langlais@st.com>
---
drivers/tty/serial/8250/8250.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
index cf6a538..3255014 100644
--- a/drivers/tty/serial/8250/8250.c
+++ b/drivers/tty/serial/8250/8250.c
@@ -1026,15 +1026,6 @@ static void autoconfig_16550a(struct uart_8250_port *up)
return;
}
-
- /*
- * We distinguish between 16550A and U6 16550A by counting
- * how many bytes are in the FIFO.
- */
- if (up->port.type == PORT_16550A && size_fifo(up) == 64) {
- up->port.type = PORT_U6_16550A;
- up->capabilities |= UART_CAP_AFE;
- }
}
/*
--
1.7.9.5
next reply other threads:[~2013-03-19 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 19:50 Philippe Langlais [this message]
2013-03-20 17:21 ` [PATCH] tty: serial: 8250: remove U6715 16550A auto-detection Greg Kroah-Hartman
2013-03-21 8:28 ` Heikki Krogerus
2013-03-21 8:36 ` Philippe LANGLAIS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363722609-20021-1-git-send-email-philippe.langlais@st.com \
--to=philippe.langlais@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=hp@oeri.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox