From: Fabio Estevam <fabio.estevam@freescale.com>
To: gregkh@linuxfoundation.org
Cc: s.hauer@pengutronix.de, linux@roeck-us.net,
linux-serial@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: [PATCH] serial: i.MX: do not allow to build as module
Date: Mon, 7 Oct 2013 09:44:32 -0300 [thread overview]
Message-ID: <1381149872-13646-1-git-send-email-fabio.estevam@freescale.com> (raw)
From: Sascha Hauer <s.hauer@pengutronix.de>
Commit f7d2c0bbdb (serial: i.MX: evaluate linux,stdout-path property) adds a
call to add_preferred_console() into drivers/tty/serial/imx.c. The file can be
built as module, yet add_preferred_console() is not exported.
Fix the build failure by disabling module build for the i.MX driver.
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/tty/serial/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 701ca60..47a05fd 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -551,7 +551,7 @@ config BFIN_UART3_CTSRTS
Enable hardware flow control in the driver.
config SERIAL_IMX
- tristate "IMX serial port support"
+ bool "IMX serial port support"
depends on ARCH_MXC
select SERIAL_CORE
select RATIONAL
--
1.8.1.2
next reply other threads:[~2013-10-07 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 12:44 Fabio Estevam [this message]
2013-10-08 2:06 ` [PATCH] serial: i.MX: do not allow to build as module Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381149872-13646-1-git-send-email-fabio.estevam@freescale.com \
--to=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).