From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Aniket RANDIVE <aniket.randive@oss.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] serial: qcom-geni: Fix port_ida handling for console and probe errors
Date: Tue, 1 Sep 2026 11:57:02 +0200 [thread overview]
Message-ID: <1383bc62-fcc6-4d5d-a4e3-b2b6ebadc0b1@oss.qualcomm.com> (raw)
In-Reply-To: <5be318fd-5413-4d6e-a8c0-f1b1eb35393a@oss.qualcomm.com>
On 8/31/26 5:59 PM, Aniket RANDIVE wrote:
>
>
> On 8/31/2026 5:08 PM, Konrad Dybcio wrote:
>> On 8/31/26 1:12 PM, Aniket Randive wrote:
>>> The console port uses a fixed line number and is not allocated from
>>> port_ida. However, qcom_geni_serial_remove() unconditionally frees the
>>> line number for all ports, including the console port.
[...]
> Thanks for catching this.
>
> Looking closer, this appears to be a separate issue from the port_ida fixes in this patch. The dev_pm_domain_detach_list() problem already exists in the current error path and is not introduced by this change.
>
> Since this involves power-domain cleanup rather than port_ida handling, I'd prefer to address it in a separate follow-up patch to keep this fix focused and easier to review.
>
> Is it OK to keep this patch limited to the port_ida fixes and handle the power-domain cleanup separately?
Yes
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
prev parent reply other threads:[~2026-09-01 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 11:12 [PATCH v2] serial: qcom-geni: Fix port_ida handling for console and probe errors Aniket Randive
2026-08-31 11:28 ` sashiko-bot
2026-08-31 11:38 ` Konrad Dybcio
2026-08-31 15:59 ` Aniket RANDIVE
2026-09-01 5:00 ` Praveen Talari
2026-09-01 9:57 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383bc62-fcc6-4d5d-a4e3-b2b6ebadc0b1@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=aniket.randive@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox