From: Peter Hurley <peter@hurleysoftware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH tty-next 0/4] tty: Fix ^C echo
Date: Mon, 2 Dec 2013 16:12:01 -0500 [thread overview]
Message-ID: <1386018725-4781-1-git-send-email-peter@hurleysoftware.com> (raw)
Greg,
Sometimes when interrupting terminal output, the '^C' won't be echoed
until more output is echoed. This is fairly repeatable by interrupting
'cat large-file'.
The common reason for this is because the tty write buffer is full,
even though the write buffer _should_ have been flushed already.
Because of a known deadlock, the pty driver does not perform a
write buffer flush in its flush_buffer() method.
[Refer to the FIXME in pty_flush_buffer() from commit
d945cb9cce20ac7143c2de8d88b187f62db99bdc,
'pty: Rework the pty layer to use the normal buffering logic']
Patch 1 fixes a stale comment.
Patch 2 adds the necessary interfaces to avoid direct linkage
between the N_TTY line discipline and the pty driver.
Patch 3 avoids the deadlock while performing the write buffer flush.
Patch 4 fixes a less common condition introduced by the echo batch
processing added in 3.12.
Alan,
I cc'd you because of your recent involvement in other
tty patches/bug fixes and because it's your FIXME comment.
Feel free to ignore and/or let me know you would prefer not to
be bothered.
Regards,
Peter Hurley (4):
tty: Fix stale tty_buffer_flush() comment
tty: Add flush_nested() tty driver method and accessor
tty: Fix pty flush
n_tty: Flush echoes for signal chars
drivers/tty/n_tty.c | 8 +++--
drivers/tty/pty.c | 32 ++++++++++++++++++-
drivers/tty/tty_buffer.c | 79 ++++++++++++++++++++++++++++++++++++++++++++--
drivers/tty/tty_ioctl.c | 21 ++++++++++++
include/linux/tty.h | 1 +
include/linux/tty_driver.h | 1 +
include/linux/tty_flip.h | 2 ++
7 files changed, 137 insertions(+), 7 deletions(-)
--
1.8.1.2
next reply other threads:[~2013-12-02 21:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 21:12 Peter Hurley [this message]
2013-12-02 21:12 ` [PATCH tty-next 1/4] tty: Fix stale tty_buffer_flush() comment Peter Hurley
2013-12-02 21:12 ` [PATCH tty-next 2/4] tty: Add flush_nested() tty driver method and accessor Peter Hurley
2013-12-02 21:12 ` [PATCH tty-next 3/4] tty: Fix pty flush Peter Hurley
2013-12-02 21:12 ` [PATCH tty-next 4/4] n_tty: Flush echoes for signal chars Peter Hurley
2013-12-03 0:01 ` [PATCH tty-next 0/4] tty: Fix ^C echo One Thousand Gnomes
2013-12-03 3:22 ` Peter Hurley
2013-12-03 14:20 ` One Thousand Gnomes
2013-12-03 17:23 ` Convert termios to RCU (was Re: [PATCH tty-next 0/4] tty: Fix ^C echo) Peter Hurley
2013-12-04 0:14 ` Peter Hurley
2013-12-04 17:42 ` [PATCH tty-next 0/4] tty: Fix ^C echo Peter Hurley
2013-12-05 0:13 ` One Thousand Gnomes
2013-12-12 3:59 ` Peter Hurley
2013-12-12 15:44 ` One Thousand Gnomes
2013-12-09 1:12 ` Greg Kroah-Hartman
2013-12-09 13:19 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386018725-4781-1-git-send-email-peter@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).