From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Pargmann Subject: [PATCH] serial: omap-serial: Move info message to probe function Date: Fri, 24 Jan 2014 18:09:41 +0100 Message-ID: <1390583381-9076-1-git-send-email-mpa@pengutronix.de> Return-path: Sender: linux-omap-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: linux-omap@vger.kernel.org, linux-serial@vger.kernel.org, kernel@pengutronix.de, Markus Pargmann , Tony Lindgren List-Id: linux-serial@vger.kernel.org Currently the info message about a missing wakeirq for uart is printed every time the serial driver's startup function is called. This happens multiple times and not just once. This patch moves the infomessage to the probe function to display it only once. Cc: Tony Lindgren Signed-off-by: Markus Pargmann --- drivers/tty/serial/omap-serial.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index fa511eb..2051581 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -738,9 +738,6 @@ static int serial_omap_startup(struct uart_port *port) return retval; } disable_irq(up->wakeirq); - } else { - dev_info(up->port.dev, "no wakeirq for uart%d\n", - up->port.line); } dev_dbg(up->port.dev, "serial_omap_startup+%d\n", up->port.line); @@ -1687,6 +1684,9 @@ static int serial_omap_probe(struct platform_device *pdev) up->port.iotype = UPIO_MEM; up->port.irq = uartirq; up->wakeirq = wakeirq; + if (!up->wakeirq) + dev_info(up->port.dev, "no wakeirq for uart%d\n", + up->port.line); up->port.regshift = 2; up->port.fifosize = 64; -- 1.8.5.2