From: Alexander Shiyan <shc_work@mail.ru>
To: linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>, Alexander Shiyan <shc_work@mail.ru>
Subject: [PATCH 3/6] serial: max310x: Remove init() and exit() callbacks
Date: Fri, 7 Feb 2014 18:16:05 +0400 [thread overview]
Message-ID: <1391782568-19442-4-git-send-email-shc_work@mail.ru> (raw)
In-Reply-To: <1391782568-19442-1-git-send-email-shc_work@mail.ru>
These callbacks were previously used for the IC power initialization.
If this initialization will be needed in the future, it should be
implemented with the regulator API.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
drivers/tty/serial/max310x.c | 7 -------
include/linux/platform_data/max310x.h | 4 ----
2 files changed, 11 deletions(-)
diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
index 313bdf0..202c1fb 100644
--- a/drivers/tty/serial/max310x.c
+++ b/drivers/tty/serial/max310x.c
@@ -1135,10 +1135,6 @@ static int max310x_probe(struct device *dev, int is_spi,
return PTR_ERR(s->regmap);
}
- /* Board specific configure */
- if (s->pdata->init)
- s->pdata->init();
-
/* Check device to ensure we are talking to what we expect */
ret = devtype->detect(dev);
if (ret)
@@ -1265,9 +1261,6 @@ static int max310x_remove(struct device *dev)
ret = gpiochip_remove(&s->gpio);
#endif
- if (s->pdata->exit)
- s->pdata->exit();
-
return ret;
}
diff --git a/include/linux/platform_data/max310x.h b/include/linux/platform_data/max310x.h
index dd11dcd..5f4b35d 100644
--- a/include/linux/platform_data/max310x.h
+++ b/include/linux/platform_data/max310x.h
@@ -55,10 +55,6 @@ struct max310x_pdata {
const int frequency;
/* GPIO base number (can be negative) */
const int gpio_base;
- /* Called during startup */
- void (*init)(void);
- /* Called before finish */
- void (*exit)(void);
};
#endif
--
1.8.3.2
next prev parent reply other threads:[~2014-02-07 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 14:16 [PATCH 0/6] serial: max310x: Improve driver. Part 1 Alexander Shiyan
2014-02-07 14:16 ` [PATCH 1/6] serial: max310x: Allow driver to be compiled as module Alexander Shiyan
2014-02-07 14:16 ` [PATCH 2/6] serial: max310x: Setup baud rate generator more precisely Alexander Shiyan
2014-02-07 14:16 ` Alexander Shiyan [this message]
2014-02-07 14:16 ` [PATCH 4/6] serial: max310x: Remove excess port configure at startup Alexander Shiyan
2014-02-07 14:16 ` [PATCH 5/6] serial: max310x: Add the loopback mode support Alexander Shiyan
2014-02-07 14:16 ` [PATCH 6/6] serial: max310x: Remove IRQ validation Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391782568-19442-4-git-send-email-shc_work@mail.ru \
--to=shc_work@mail.ru \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).