From: Soren Brinkmann <soren.brinkmann@xilinx.com>
To: Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>, Arnd Bergmann <arnd@arndb.de>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Michal Simek <michal.simek@xilinx.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org,
Soren Brinkmann <soren.brinkmann@xilinx.com>
Subject: [PATCH RFC v2 00/11] tty: xuartps: Rebranding
Date: Fri, 7 Mar 2014 11:13:23 -0800 [thread overview]
Message-ID: <1394219614-3197-1-git-send-email-soren.brinkmann@xilinx.com> (raw)
A second iteration of this series.
I added some more to the cleanup parts. The more you look at things the
more things to fix you find.
The read-modify-write refactoring is more or less a result of the prefix
substitution. With the changed prefix for better indentation is
necessary, and I think it makes the code more readably in general.
The controversial part, the re-branding: I split this up into 4 separate
patches, starting at 5/8. Each going a little further and I'd like to
know which ones are wanted/okay and which rather not. And whether the
wanted ones should be squashed.
The first one is pretty much the light-weight changes Alan suggested.
The second changes the driver name. I don't know if that is acceptable.
I think the name is used in some sysfs nodes. Does that make it part of
the userspace API? And I don't know if the name might be used elsewhere?
The third is mostly a search and replace of 'xuartps' with
'cdns-uart'. A noisy change but it should not impact anything else. I
thought it might be nice to have more generic names since they show in
stack traces and the xuartps thing may not be that meaningful on
non-Zynq platforms - though there is non for this driver as of now.
Similar the Kconfig symbol renaming. Probably not worth it, but might
clarify things a bit.
The defconfig update would - obviously - only needed if the Kconfig
change is done. Which is probably another reason to not change the
config symbol.
In the documentation I added xlnx,xuartps as valid compatible string,
but refrained from documenting the Zynq-specific clock names. The
driver, though, allows them, but prints a warning.
The DT update would silence the afore-mentioned warning by migrating to
the new clock names.
Thanks,
Sören
Soren Brinkmann (11):
tty: xuartps: Clean up
tty: xuartps: Print warning in clock notifier
tty: xuartps: Refactor read-modify-writes
tty: xuartps: Remove bogus comment and register write
tty: xuartps: Rebrand driver as Cadence UART
tty: xuartps: Change driver name to 'cdns-uart'
tty: xuartps: Replace function and symbol prefix
tty: xuartps: Rename Kconfig symbols
ARM: multi_v7_defconfig: Adopt to UART driver renaming
tty: cadence: Document DT binding
ARM: zynq: DT: Migrate UART to Cadence binding
.../devicetree/bindings/serial/cdns,uart.txt | 20 +
arch/arm/boot/dts/zynq-7000.dtsi | 8 +-
arch/arm/configs/multi_v7_defconfig | 4 +-
drivers/tty/serial/Kconfig | 15 +-
drivers/tty/serial/Makefile | 2 +-
drivers/tty/serial/xilinx_uartps.c | 1123 ++++++++++----------
include/uapi/linux/serial_core.h | 2 +-
7 files changed, 569 insertions(+), 605 deletions(-)
create mode 100644 Documentation/devicetree/bindings/serial/cdns,uart.txt
--
1.9.0.1.g4196000
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2014-03-07 19:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 19:13 Soren Brinkmann [this message]
2014-03-07 19:13 ` [PATCH RFC v2 01/11] tty: xuartps: Clean up Soren Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 02/11] tty: xuartps: Print warning in clock notifier Soren Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 03/11] tty: xuartps: Refactor read-modify-writes Soren Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 04/11] tty: xuartps: Remove bogus comment and register write Soren Brinkmann
2014-03-07 21:28 ` One Thousand Gnomes
2014-03-07 23:08 ` Sören Brinkmann
2014-03-08 21:57 ` One Thousand Gnomes
2014-03-07 19:13 ` [PATCH RFC v2 05/11] tty: xuartps: Rebrand driver as Cadence UART Soren Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 06/11] tty: xuartps: Change driver name to 'cdns-uart' Soren Brinkmann
2014-03-07 21:29 ` One Thousand Gnomes
2014-03-07 22:58 ` Sören Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 07/11] tty: xuartps: Replace function and symbol prefix Soren Brinkmann
2014-03-07 23:53 ` Sören Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 08/11] tty: xuartps: Rename Kconfig symbols Soren Brinkmann
2014-03-07 21:30 ` One Thousand Gnomes
2014-03-07 22:59 ` Sören Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 09/11] ARM: multi_v7_defconfig: Adopt to UART driver renaming Soren Brinkmann
2014-03-07 23:16 ` Sören Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 10/11] tty: cadence: Document DT binding Soren Brinkmann
2014-03-08 19:34 ` Rob Herring
2014-03-07 19:13 ` [PATCH RFC v2 11/11] ARM: zynq: DT: Migrate UART to Cadence binding Soren Brinkmann
2014-03-08 19:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394219614-3197-1-git-send-email-soren.brinkmann@xilinx.com \
--to=soren.brinkmann@xilinx.com \
--cc=arnd@arndb.de \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=peter.crosthwaite@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).