From: Joe Perches <joe@perches.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Simon Horman <horms+renesas@verge.net.au>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-serial@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Subject: Re: [PATCH 1/4] serial: sh-sci: Replace printk() by pr_*()
Date: Tue, 11 Mar 2014 07:27:40 -0700 [thread overview]
Message-ID: <1394548060.21085.45.camel@joe-AO722> (raw)
In-Reply-To: <1394532680-4264-1-git-send-email-geert@linux-m68k.org>
On Tue, 2014-03-11 at 11:11 +0100, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>
> Make banner const while we're at it
One thing to consider is to add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any #include to make sure all messages
are appropriately prefixed by subsystem name.
One day, I'd very much like to avoid this
by making it the default.
http://comments.gmane.org/gmane.linux.kernel/1052288
next prev parent reply other threads:[~2014-03-11 14:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 10:11 [PATCH 1/4] serial: sh-sci: Replace printk() by pr_*() Geert Uytterhoeven
2014-03-11 10:11 ` [PATCH 2/4] serial: sh-sci: Remove useless casts Geert Uytterhoeven
2014-03-11 10:11 ` [PATCH 3/4] serial: sh-sci: Add more register documentation Geert Uytterhoeven
2014-03-11 10:11 ` [PATCH 4/4] serial: sh-sci: Replace hardcoded 3 by UART_PM_STATE_OFF Geert Uytterhoeven
2014-03-11 10:30 ` [PATCH 1/4] serial: sh-sci: Replace printk() by pr_*() Laurent Pinchart
2014-03-13 1:47 ` Simon Horman
2014-03-11 14:27 ` Joe Perches [this message]
2014-03-11 17:10 ` [PATCH] serial: sh-sci: Neaten dev_<level> uses Joe Perches
2014-03-12 18:55 ` Geert Uytterhoeven
2014-03-13 1:48 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394548060.21085.45.camel@joe-AO722 \
--to=joe@perches.com \
--cc=geert+renesas@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms+renesas@verge.net.au \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).