From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Subject: [PATCH] serial: mux: Align SUPPORT_SYSRQ behaviour with other drivers. Date: Fri, 28 Mar 2014 11:41:38 +0000 Message-ID: <1396006898-31624-1-git-send-email-daniel.thompson@linaro.org> Return-path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:34511 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984AbaC1LmN (ORCPT ); Fri, 28 Mar 2014 07:42:13 -0400 Received: by mail-wg0-f44.google.com with SMTP id m15so3416108wgh.3 for ; Fri, 28 Mar 2014 04:42:12 -0700 (PDT) Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: linux-serial@vger.kernel.org Cc: patches@linaro.org, linaro-kernel@lists.linaro.org, Daniel Thompson , Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, Jiri Kosina The mux driver is anomalous among all the serial drivers that can define SUPPORT_SYSRQ because it can, with some configs, set SUPPORT_SYSRQ when SERIAL_CORE_CONSOLE is not set. Not only does this impose a pointless (but tiny) runtime overhead for such configs but, more significantly, it adds needless complexity when doing a code review to check for unexpected side effects of any changes to the serial core. This is (cross-)compile tested only because I do not have any PA-RISC hardware. Signed-off-by: Daniel Thompson --- drivers/tty/serial/mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/mux.c b/drivers/tty/serial/mux.c index 7fd6aaa..9b27d34 100644 --- a/drivers/tty/serial/mux.c +++ b/drivers/tty/serial/mux.c @@ -29,7 +29,7 @@ #include #include -#ifdef CONFIG_MAGIC_SYSRQ +#if defined(CONFIG_SERIAL_MUX_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ) #include #define SUPPORT_SYSRQ #endif -- 1.9.0