Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Christian Engelmayer <cengelma@gmx.at>
Cc: linux-serial@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>, Jingoo Han <jg1.han@samsung.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: samsung: Fix compile error with SERIAL_SAMSUNG_DEBUG
Date: Sat, 14 Jun 2014 13:33:56 -0700	[thread overview]
Message-ID: <1402778036.2756.24.camel@joe-AO725> (raw)
In-Reply-To: <1402776434-31613-1-git-send-email-cengelma@gmx.at>

Greg?  Can you please apply this soon?

Thanks.

On Sat, 2014-06-14 at 22:07 +0200, Christian Engelmayer wrote:
> Commit e4ac92d (serial: samsung: Neaten dbg uses) contains a typo in the
> changed dbg() function regarding the name of the used character buffer.
> This breaks the build if actually compiled with CONFIG_SERIAL_SAMSUNG_DEBUG.
> 
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
> Compile tested. Applies against branch tty-next in tree
> git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> ---
>  drivers/tty/serial/samsung.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 3293377..c1d3ebd 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -66,7 +66,7 @@ static void dbg(const char *fmt, ...)
>  	char buff[256];
>  
>  	va_start(va, fmt);
> -	vscnprintf(buff, sizeof(buf), fmt, va);
> +	vscnprintf(buff, sizeof(buff), fmt, va);
>  	va_end(va);
>  
>  	printascii(buff);

  reply	other threads:[~2014-06-14 20:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-14 20:07 [PATCH] serial: samsung: Fix compile error with SERIAL_SAMSUNG_DEBUG Christian Engelmayer
2014-06-14 20:33 ` Joe Perches [this message]
2014-06-15 17:36   ` Sachin Kamat
2014-06-15 17:46     ` Joe Perches
2014-06-16 21:29       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402778036.2756.24.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=cengelma@gmx.at \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox