* [PATCH 0/2] use correct type for dma_map/unmap
@ 2014-07-21 9:42 Wolfram Sang
2014-07-21 9:42 ` [PATCH 2/2] drivers/tty/serial: " Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2014-07-21 9:42 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Wolfram Sang, linux-i2c, linux-kernel, linux-serial
I recently stumbled over the fact that the Atmel I2C driver used a wrong enum
for mapping dma, so I wrote a hackish coccinelle script to check the rest of the
kernel. Luckily, only those two were found.
Wolfram Sang (2):
drivers/i2c/busses: use correct type for dma_map/unmap
drivers/tty/serial: use correct type for dma_map/unmap
drivers/i2c/busses/i2c-at91.c | 4 ++--
drivers/tty/serial/atmel_serial.c | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
--
2.0.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/2] drivers/tty/serial: use correct type for dma_map/unmap
2014-07-21 9:42 [PATCH 0/2] use correct type for dma_map/unmap Wolfram Sang
@ 2014-07-21 9:42 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2014-07-21 9:42 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Wolfram Sang, Nicolas Ferre, Greg Kroah-Hartman, Jiri Slaby,
linux-serial, linux-kernel
dma_{un}map_* uses 'enum dma_data_direction' not 'enum dma_transfer_direction'.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/tty/serial/atmel_serial.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index c4f750314100..7b63677475c1 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -706,7 +706,7 @@ static void atmel_release_tx_dma(struct uart_port *port)
dmaengine_terminate_all(chan);
dma_release_channel(chan);
dma_unmap_sg(port->dev, &atmel_port->sg_tx, 1,
- DMA_MEM_TO_DEV);
+ DMA_TO_DEVICE);
}
atmel_port->desc_tx = NULL;
@@ -804,7 +804,7 @@ static int atmel_prepare_tx_dma(struct uart_port *port)
nent = dma_map_sg(port->dev,
&atmel_port->sg_tx,
1,
- DMA_MEM_TO_DEV);
+ DMA_TO_DEVICE);
if (!nent) {
dev_dbg(port->dev, "need to release resource of dma\n");
@@ -883,7 +883,7 @@ static void atmel_release_rx_dma(struct uart_port *port)
dmaengine_terminate_all(chan);
dma_release_channel(chan);
dma_unmap_sg(port->dev, &atmel_port->sg_rx, 1,
- DMA_DEV_TO_MEM);
+ DMA_FROM_DEVICE);
}
atmel_port->desc_rx = NULL;
@@ -968,7 +968,7 @@ static int atmel_prepare_rx_dma(struct uart_port *port)
nent = dma_map_sg(port->dev,
&atmel_port->sg_rx,
1,
- DMA_DEV_TO_MEM);
+ DMA_FROM_DEVICE);
if (!nent) {
dev_dbg(port->dev, "need to release resource of dma\n");
--
2.0.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-21 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-21 9:42 [PATCH 0/2] use correct type for dma_map/unmap Wolfram Sang
2014-07-21 9:42 ` [PATCH 2/2] drivers/tty/serial: " Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).