Re: [PATCH] serial: atmel: add missing dmaengine header

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, 2014-10-16 at 13:09 +0530, Vinod Koul wrote:
> The atmel serial driver uses dmaengine APIs but never included the dmaengine
> header as it was getting inculded thru one of driver headers.
> 
> commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split
> dma-dw.h to platform and private parts" broke this as it moved headers
> around.  Fix this by doing the right thing to include the dmaengine header
> 

Thanks, I just sent similar idea to Fengguang and you.

I don't know if it would be a stable material. If so, it would be nice
to add:

Fixes: 08f738be88bb (serial: at91: add tx dma support)
Cc: stable@vger.kernel.org

> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> ---
> Greg, since this is path which broke this is sitting in my next, would it be
> okay to carry this thru dmaengine tree as get it merged in current window.
> Planning to send pull request in day or so to Linus
> 
>  drivers/tty/serial/atmel_serial.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index d7d4584..edde3ec 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -37,6 +37,7 @@
>  #include <linux/of_device.h>
>  #include <linux/of_gpio.h>
>  #include <linux/dma-mapping.h>
> +#include <linux/dmaengine.h>
>  #include <linux/atmel_pdc.h>
>  #include <linux/atmel_serial.h>
>  #include <linux/uaccess.h>


-- 
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy