From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Subject: [PATCH v2 2/2] usb: gadget serial: Honour termios CLOCAL on disconnect Date: Mon, 3 Nov 2014 17:18:05 +0200 Message-ID: <1415027885-2181-3-git-send-email-kyosti.malkki@gmail.com> References: <1414346490-19307-1-git-send-email-kyosti.malkki@gmail.com> <1415027885-2181-1-git-send-email-kyosti.malkki@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1415027885-2181-1-git-send-email-kyosti.malkki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org List-Id: linux-serial@vger.kernel.org There are applications where it is desirable to not hangup ttyGS* when USB disconnect is detected. USB host side of communication may power-cycle periodically or there may be the actual need to physically disconnect and reconnect USB cable temporarily. USB disconnects on serial gadget are comparable to loss of Carrier Dete= ct of conventional UARTs. With the change, if ttyGS* has termios CLOCAL fl= ag set, disconnect on USB does not hangup the TTY. Signed-off-by: Ky=C3=B6sti M=C3=A4lkki --- drivers/usb/gadget/function/u_serial.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadge= t/function/u_serial.c index 491082a..dabc165 100644 --- a/drivers/usb/gadget/function/u_serial.c +++ b/drivers/usb/gadget/function/u_serial.c @@ -1253,9 +1253,16 @@ void gserial_disconnect(struct gserial *gser) port->port_usb =3D NULL; gser->ioport =3D NULL; if (port->port.count > 0 || port->openclose) { + struct tty_struct *tty; + wake_up_interruptible(&port->drain_wait); - if (port->port.tty) - tty_hangup(port->port.tty); + tty =3D port->port.tty; + if (tty) { + if (tty->termios.c_cflag & CLOCAL) + stop_tty(tty); + else + tty_hangup(tty); + } } spin_unlock_irqrestore(&port->port_lock, flags); =20 --=20 1.8.1.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html