[PATCH] serial: sh-sci: Use dev_dbg() to log an error message

[PATCH] serial: sh-sci: Use dev_dbg() to log an error message

[Yoshihiro Kaneko]

Since the driver cannot return from overrun error if characters
are output during overrun process, use dev_dbg() instead of
dev_notice() to log the error message of overrun in syslog.

Based on a patch by Hisashi Nakamura.

Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---

This patch is based on the tty-next branch of Greg Kroah-Hartman's tty
tree.

 drivers/tty/serial/sh-sci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index 69f6bf3..9688e74 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -864,7 +864,7 @@ static int sci_handle_fifo_overrun(struct uart_port *port)
 		tty_insert_flip_char(tport, 0, TTY_OVERRUN);
 		tty_flip_buffer_push(tport);
 
-		dev_notice(port->dev, "overrun error\n");
+		dev_dbg(port->dev, "overrun error\n");
 		copied++;
 	}
 
-- 
1.9.1

Re: [PATCH] serial: sh-sci: Use dev_dbg() to log an error message

[Geert Uytterhoeven]

On Mon, Jan 26, 2015 at 12:53 PM, Yoshihiro Kaneko
<ykaneko0929@gmail.com> wrote:
> Since the driver cannot return from overrun error if characters
> are output during overrun process, use dev_dbg() instead of
> dev_notice() to log the error message of overrun in syslog.
>
> Based on a patch by Hisashi Nakamura.
>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds