From: Alan Cox <alan@linux.intel.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Peter Huewe <PeterHuewe@gmx.de>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
peter_hong@fintek.com.tw
Subject: Re: [PATCH 5/5] serial/8250_fintek: Support for any io address.
Date: Mon, 15 Jun 2015 15:25:58 +0100 [thread overview]
Message-ID: <1434378358.25843.11.camel@linux.intel.com> (raw)
In-Reply-To: <1434377926-31958-6-git-send-email-ricardo.ribalda@gmail.com>
On Mon, 2015-06-15 at 16:18 +0200, Ricardo Ribalda Delgado wrote:
> Fintek chip can be configured for io addresses different than the standard.
>
> Query the chip for the configured addresses and try to match it with the
> pnp address.
Looks ok to me. I am a little concerned about false positives but it
does everything right in terms of resource management so I guess it
should be ok - and if not we are only going to find the corner case that
blows up by shipping it 8)
Please however fix the dynamic on stack arrays you've got. Doing
blah foo[] = { 1,2,3,4 };
might well be valid gcc but it generates horrible code when in fact your
arrays should be static/const, not dynamically constructed on stack from
a static copy each call.
Reviewed-by: Alan Cox <alan@linux.intel.com>
next prev parent reply other threads:[~2015-06-15 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 14:18 [PATCH 0/5] serial/8250_fintek Support any configuration Ricardo Ribalda Delgado
2015-06-15 14:18 ` [PATCH 1/5] serial/8250_fintek: Use private data structure Ricardo Ribalda Delgado
2015-06-15 14:18 ` [PATCH 2/5] serial/8250_fintek: Support for multiple base_ports Ricardo Ribalda Delgado
2015-06-15 14:18 ` [PATCH 3/5] serial/8250_fintek: Support for chip_ip 0x0501 Ricardo Ribalda Delgado
2015-06-15 14:18 ` [PATCH 4/5] serial/8250_fintek: Support keys different than default Ricardo Ribalda Delgado
2015-06-15 14:18 ` [PATCH 5/5] serial/8250_fintek: Support for any io address Ricardo Ribalda Delgado
2015-06-15 14:25 ` Alan Cox [this message]
2015-06-15 15:22 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434378358.25843.11.camel@linux.intel.com \
--to=alan@linux.intel.com \
--cc=PeterHuewe@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
--cc=rafael.j.wysocki@intel.com \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).